feat(esp-box-3): Support I2C Driver-NG #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tore-espressif
force-pushed
the
refactor/esp_box_3_driver_ng
branch
5 times, most recently
from
f0f4809
to
812d182
Compare
espzav
approved these changes
Nov 5, 2024
There was a problem hiding this comment.
@tore-espressif Thank you for this PR and for the fix my accelerometter issues :-)
LGTM
tore-espressif
force-pushed
the
refactor/esp_box_3_driver_ng
branch
from
812d182
to
b1e8a42
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update esp-box-3 to driver-NG
In the end I had to add
i2c_master_bus_handle_t bsp_i2c_get_handle(void);because IDF functioni2c_master_get_bus_handleis only present in IDF v5.4 and was not backportedAnyway, we depend on v5.3 because of esp_codec_dev which does not support Driver-NG in v5.2