Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement stake/unstake/extend methods (#418) #474

Merged
merged 26 commits into from
Jul 8, 2024
Merged

implement stake/unstake/extend methods (#418) #474

merged 26 commits into from
Jul 8, 2024

Conversation

doerfli
Copy link
Contributor

@doerfli doerfli commented Jul 2, 2024 •
edited
Loading

  • stake bundle
  • testcases for stake happy path
  • testcase for stake allowance too small
  • testcase for stake amount zero
  • testcase for stake amount bundle expired
  • testcase for stake amount bundle closed
  • unstake bundle
  • testcases for unstake happy path
  • testcases for unstake max amount
  • testcases for unstake more than available (locked)
  • testcases for unstake allowance too small
  • testcases for unstake amount zero
  • extend bundle
  • testcases for extend happy path
  • testcases for extend on expired/closed bundle
  • testcase lifetime is zero

@doerfli doerfli linked an issue Jul 2, 2024 that may be closed by this pull request
Pool: Bundle Handling: Add (Un)Stake/Extend functionality #418
Closed
@doerfli doerfli changed the title add stake/unstake methods (#418) implement stake/unstake methods (#418) Jul 2, 2024
@doerfli doerfli force-pushed the feature/bundle-stake-unstake-extend branch from e664e06 to 7032395 Compare July 2, 2024 14:44
@doerfli doerfli force-pushed the feature/bundle-stake-unstake-extend branch from d2d9c09 to ed90874 Compare July 2, 2024 15:26
doerfli added 18 commits July 3, 2024 07:29
@doerfli
implement expire bundle (#418)
80b9543
@doerfli
add TODOs (#418)
b260da0
@doerfli
replace IBundle.lifetime with IBundle.activatedAt (#418)
b8ad371
@doerfli
implement stake (#418)
0ab05fb
@doerfli
implement unstake without performance fees (#418)
0687846
@doerfli
add happy day testcase for bundle staking (#418)
bab6a62
@doerfli
add test for allowance too small (#418)
65fdd19
@doerfli
test for amount is zero (#418)
f87b2b7
@doerfli
add test for expired and closed bundle (#418)
31e59c2
@doerfli
add testcase for unstake happy path (#418)
2c10528
@doerfli
unstake all available (#418)
69ccd9f
@doerfli
test for unstake exceeds available (#418)
0354ccb
@doerfli
add test for amount is zero (#418)
84325da
@doerfli
add testcase for allowance too small (#418)
437f3a8
@doerfli
add testcase for bundle extension (#418)
ce1250f
@doerfli
add tests for expired and closed bundle (#418)
048dfa1
@doerfli
add testcase for lifetime is zero (#418)
1e176b6
@doerfli
remove productNftId from PoolInfo
34c5786
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 3, 2024

Todo Commenter

contracts/pool/BundleService.sol
TODO:
contracts/pool/IPoolService.sol
TODO:
  • return netAmount Line: 106
contracts/pool/PoolService.sol
TODO:

@doerfli Please take a look 👀

@doerfli doerfli changed the title implement stake/unstake methods (#418) implement stake/unstake/extend methods (#418) Jul 4, 2024
@doerfli doerfli merged commit d7b5510 into develop Jul 8, 2024
11 checks passed
@doerfli doerfli deleted the feature/bundle-stake-unstake-extend branch July 8, 2024 08:25
@github-actions github-actions bot locked and limited conversation to collaborators Jul 8, 2024
matthiaszimmermann
matthiaszimmermann reviewed Jul 8, 2024
View reviewed changes
contracts/pool/BundleService.sol Show resolved Hide resolved
contracts/pool/BundleService.sol Show resolved Hide resolved
contracts/pool/BundleService.sol Show resolved Hide resolved
contracts/pool/BundleService.sol Show resolved Hide resolved
contracts/pool/BundleService.sol Show resolved Hide resolved
contracts/pool/PoolService.sol Show resolved Hide resolved
contracts/pool/PoolService.sol Show resolved Hide resolved
contracts/pool/PoolService.sol Show resolved Hide resolved
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@matthiaszimmermann matthiaszimmermann matthiaszimmermann left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pool: Bundle Handling: Add (Un)Stake/Extend functionality
2 participants
@doerfli @matthiaszimmermann