chore: add tests for NewOverlayFromEthereumAddress method #4485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
@notanatol I have reopened the PR with the suggested updates. |
mrekucci
reviewed
Nov 29, 2023
notanatol
changed the title
NewOverlayFromEthereumAddressNewOverlayFromEthereumAddress
notanatol
changed the title
NewOverlayFromEthereumAddress
thanks, but you don't have to re-open the PR, just push the fix commits to this branch, they are squashed anyway as we merge to master. |
…ss & made the suggested changes
mrekucci
reviewed
Dec 4, 2023
| t.Errorf("got address length %v, want %v", l, swarm.HashSize) | ||
| } | ||
|
|
||
| wantAddress, err := swarm.ParseHexAddress(tc.expectedAddress) |
There was a problem hiding this comment.
This step can be avoided by using swarm.MustParseHexAddress function in the test table.
There was a problem hiding this comment.
only line 303 or from 299?
There was a problem hiding this comment.
because MustParseHexAddress is not taking account of the length of the hash
There was a problem hiding this comment.
This is just for the tc.expectedAddress.
notanatol
approved these changes
Dec 12, 2023
acha-bill
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added 4 test cases under
TestNewOverlayFromEthereumAddressto testNewOverlayFromEthereumAddressof crypto libraryChecklist
Description
Open API Spec Version Changes (if applicable)
Motivation and Context (Optional)
Related Issue (Optional)
Screenshots (if appropriate):