Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HA-450 prereq: add user assigned data_uses and system_id properties to StagedResource #5841

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

thingscouldbeworse
Copy link
Contributor

Prerequisite for HA-450

Description Of Changes

Required for the "persistence" work, allowing users to add add data uses and systems to staged resources

Code Changes

  • migration for stagedresource adding the appropriate columns
  • model update

Steps to Confirm

  1. Check if the user_assigned_data_uses and user_assigned_system_id columns are present on stagedresource table

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

Copy link

vercel bot commented Mar 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 12, 2025 4:29pm
fides-privacy-center ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 12, 2025 4:29pm

Copy link

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.05%. Comparing base (fdb0e48) to head (b69d82f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5841      +/-   ##
==========================================
+ Coverage   86.74%   87.05%   +0.31%     
==========================================
  Files         408      408              
  Lines       25322    25324       +2     
  Branches     2727     2727              
==========================================
+ Hits        21965    22047      +82     
+ Misses       2778     2690      -88     
- Partials      579      587       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@thingscouldbeworse thingscouldbeworse changed the title HA-450 prereq: add user assigned dat_uses and system_id properties to StagedResource HA-450 prereq: add user assigned data_uses and system_id properties to StagedResource Mar 6, 2025
Copy link
Contributor

@adamsachs adamsachs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good with one minor note about the index on a new column 👍

String,
ForeignKey(System.id_field_path),
nullable=True,
index=True,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want an index here? it could make sense, though not sure it's strictly necessary. i'm good keeping it, but if so, we need to make sure we actually create/remove the index in the migration upgrade/downgrade

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed the migration in a merge apparently; added here: b829ef4

Copy link
Contributor

@adamsachs adamsachs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, lets just make sure you avoid migration downrev conflicts with your other pending PR 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants