-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HA-450 prereq: add user assigned data_uses and system_id properties to StagedResource #5841
base: main
Are you sure you want to change the base?
HA-450 prereq: add user assigned data_uses and system_id properties to StagedResource #5841
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5841 +/- ##
==========================================
+ Coverage 86.74% 87.05% +0.31%
==========================================
Files 408 408
Lines 25322 25324 +2
Branches 2727 2727
==========================================
+ Hits 21965 22047 +82
+ Misses 2778 2690 -88
- Partials 579 587 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks good with one minor note about the index on a new column 👍
String, | ||
ForeignKey(System.id_field_path), | ||
nullable=True, | ||
index=True, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we want an index here? it could make sense, though not sure it's strictly necessary. i'm good keeping it, but if so, we need to make sure we actually create/remove the index in the migration upgrade/downgrade
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missed the migration in a merge apparently; added here: b829ef4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, lets just make sure you avoid migration downrev conflicts with your other pending PR 👍
Prerequisite for HA-450
Description Of Changes
Required for the "persistence" work, allowing users to add add data uses and systems to staged resources
Code Changes
stagedresource
adding the appropriate columnsSteps to Confirm
user_assigned_data_uses
anduser_assigned_system_id
columns are present onstagedresource
tablePre-Merge Checklist
CHANGELOG.md
updatedmain
downgrade()
migration is correct and works