-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HA-450 prereq: add user assigned data_uses and system_id properties to StagedResource #5841
Open
thingscouldbeworse
wants to merge
12
commits into
main
Choose a base branch
from
HA-450_staged-resource-user-assigned-fields
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
f0542de
add user assigned dat_uses and system_id properties to StagedResource
thingscouldbeworse d261fee
changelog
thingscouldbeworse 0a463a0
merge main
thingscouldbeworse 115607e
Merge branch 'main' into HA-450_staged-resource-user-assigned-fields
thingscouldbeworse bc5b54e
Merge branch 'main' into HA-450_staged-resource-user-assigned-fields
thingscouldbeworse a98ba8f
Merge branch 'main' into HA-450_staged-resource-user-assigned-fields
thingscouldbeworse ed9b3b1
static check
thingscouldbeworse 53eab8c
revision history
thingscouldbeworse fd54ceb
more revisions
thingscouldbeworse 10b5353
Merge branch 'main' into HA-450_staged-resource-user-assigned-fields
thingscouldbeworse b829ef4
index
thingscouldbeworse b69d82f
Merge branch 'main' into HA-450_staged-resource-user-assigned-fields
thingscouldbeworse File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
54 changes: 54 additions & 0 deletions
54
...s/api/alembic/migrations/versions/7c3fbee90c78_add_user_assigned_data_uses_and_system_.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,54 @@ | ||
"""add user assigned data_uses and system_id columns to stagedresource | ||
|
||
Revision ID: 7c3fbee90c78 | ||
Revises: 69ad6d844e21 | ||
Create Date: 2025-03-04 15:00:23.874270 | ||
|
||
""" | ||
|
||
import sqlalchemy as sa | ||
from alembic import op | ||
from sqlalchemy.dialects import postgresql | ||
|
||
# revision identifiers, used by Alembic. | ||
revision = "7c3fbee90c78" | ||
down_revision = "69ad6d844e21" | ||
branch_labels = None | ||
depends_on = None | ||
|
||
|
||
def upgrade(): | ||
# ### commands auto generated by Alembic - please adjust! ### | ||
op.add_column( | ||
"stagedresource", | ||
sa.Column( | ||
"user_assigned_system_id", sa.VARCHAR(), autoincrement=False, nullable=True | ||
), | ||
) | ||
op.add_column( | ||
"stagedresource", | ||
sa.Column( | ||
"user_assigned_data_uses", | ||
postgresql.ARRAY(sa.VARCHAR()), | ||
server_default=sa.text("'{}'::character varying[]"), | ||
autoincrement=False, | ||
nullable=False, | ||
), | ||
) | ||
# ### end Alembic commands ### | ||
op.create_index( | ||
"ix_stagedresource_user_assigned_system_id", | ||
"stagedresource", | ||
["user_assigned_system_id"], | ||
unique=False, | ||
) | ||
|
||
|
||
def downgrade(): | ||
# ### commands auto generated by Alembic - please adjust! ### | ||
op.drop_column("stagedresource", "user_assigned_data_uses") | ||
op.drop_column("stagedresource", "user_assigned_system_id") | ||
# ### end Alembic commands ### | ||
op.drop_index( | ||
"ix_stagedresource_user_assigned_system_id", table_name="stagedresource" | ||
) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we want an index here? it could make sense, though not sure it's strictly necessary. i'm good keeping it, but if so, we need to make sure we actually create/remove the index in the migration upgrade/downgrade
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missed the migration in a merge apparently; added here: b829ef4