-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix MonitorExecution.started
bug
#5864
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
thingscouldbeworse
approved these changes
Mar 10, 2025
fides
|
Project |
fides
|
Branch Review |
main
|
Run status |
|
Run duration | 00m 51s |
Commit |
|
Committer | Adam Sachs |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
0
|
|
0
|
|
0
|
|
5
|
View all changes introduced in this branch ↗︎ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5864 +/- ##
=======================================
Coverage 87.01% 87.02%
=======================================
Files 407 407
Lines 25124 25125 +1
Branches 2706 2706
=======================================
+ Hits 21862 21864 +2
Misses 2678 2678
+ Partials 584 583 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes HA-487
Description Of Changes
We had a pesky little bug that was causing inaccurate
started
values in ourMonitorExecution
records. This should fix that up.Code Changes
server_default
for the current datetime (with a timestamp!) on ourstarted
columncompleted
column has the timestamp information it needsSteps to Confirm
MonitorExecution
records with application code), but i don't foresee any issuesPre-Merge Checklist
CHANGELOG.md
updatedmain
downgrade()
migration is correct and works