Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix MonitorExecution.started bug #5864

Merged
merged 7 commits into from
Mar 10, 2025
Merged

fix MonitorExecution.started bug #5864

merged 7 commits into from
Mar 10, 2025

Conversation

adamsachs
Copy link
Contributor

@adamsachs adamsachs commented Mar 10, 2025

Closes HA-487

Description Of Changes

We had a pesky little bug that was causing inaccurate started values in our MonitorExecution records. This should fix that up.

Code Changes

  • ensure we're properly setting server_default for the current datetime (with a timestamp!) on our started column
  • ensure that completed column has the timestamp information it needs

Steps to Confirm

  1. i confirmed locally that the test case failed before the fix was patched, and then succeeds with the fix in place
  2. additional testing will need to be integration tested with fidesplus (where we actually create MonitorExecution records with application code), but i don't foresee any issues

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

Copy link

vercel bot commented Mar 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-privacy-center ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 10, 2025 5:27pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Mar 10, 2025 5:27pm

@adamsachs adamsachs merged commit 49f23bc into main Mar 10, 2025
17 checks passed
@adamsachs adamsachs deleted the asachs/HA-487 branch March 10, 2025 17:37
Copy link

cypress bot commented Mar 10, 2025

fides    Run #12649

Run Properties:  status check passed Passed #12649  •  git commit 49f23bc042: fix `MonitorExecution.started` bug (#5864)
Project fides
Branch Review main
Run status status check passed Passed #12649
Run duration 00m 51s
Commit git commit 49f23bc042: fix `MonitorExecution.started` bug (#5864)
Committer Adam Sachs
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
View all changes introduced in this branch ↗︎

Copy link

codecov bot commented Mar 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.02%. Comparing base (650f70d) to head (77ec8f2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5864   +/-   ##
=======================================
  Coverage   87.01%   87.02%           
=======================================
  Files         407      407           
  Lines       25124    25125    +1     
  Branches     2706     2706           
=======================================
+ Hits        21862    21864    +2     
  Misses       2678     2678           
+ Partials      584      583    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants