Fix system asset table width #5879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jpople
commented
Mar 12, 2025
| @@ -116,7 +116,7 @@ const ConfigureSystem: NextPage = () => { | |||
| Could not find a system with id {systemId} | |||
| </Text> | |||
| ) : ( | |||
| <VStack alignItems="stretch" flex="1" gap="18px" maxWidth="70vw"> | |||
There was a problem hiding this comment.
The maxWidth was an attempt to solve this problem but was leading to the weird table width; the other props, as far as I can tell, didn't actually do anything.
gilluminate
approved these changes
Mar 12, 2025
fides
|
||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 00m 50s |
| Commit |
|
| Committer | jpople |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
5
|
| View all changes introduced in this branch ↗︎ | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes HA-479
Description Of Changes
Adjusts the width of the
mainelement on the system detail view to fix a bug with the width on the system assets table.Before:
After:
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works