Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix system asset table width #5879

Merged
merged 4 commits into from
Mar 12, 2025
Merged

Fix system asset table width #5879

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2498dad
fix system asset table width
jpople Mar 12, 2025
267568f
Merge branch 'main' into jpople/ha-479/system-asset-table-width
jpople Mar 12, 2025
1d72ea1
update changelog
jpople Mar 12, 2025
a444058
update changelog
jpople Mar 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ Changes can also be flagged with a GitHub label for tracking purposes. The URL o
- Fixed CORS origins handling to be more consistent across config (toml/env var) and API settings; allow `0.0.0.0` as an origin [#5853](https://github.com/ethyca/fides/pull/5853)
- Fixed an issue with the update payloads for select SaaS integrations [#5860](https://github.com/ethyca/fides/pull/5860)
- Fixed `/privacy-request/<id>/resubmit` endpoint so it doesn't queue the request twice [#5870](https://github.com/ethyca/fides/pull/5870)
- Fixed the system assets table being the wrong width [#5879](https://github.com/ethyca/fides/pull/5879)

## [2.56.2](https://github.com/ethyca/fides/compare/2.56.1...2.56.2)

Expand Down
4 changes: 2 additions & 2 deletions clients/admin-ui/src/pages/systems/configure/[id]/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ const ConfigureSystem: NextPage = () => {
}

return (
<Layout title="System inventory">
<Layout title="System inventory" mainProps={{ w: "calc(100vw - 240px)" }}>
<PageHeader
heading="System inventory"
breadcrumbItems={[
Expand Down Expand Up @@ -116,7 +116,7 @@ const ConfigureSystem: NextPage = () => {
Could not find a system with id {systemId}
</Text>
) : (
<VStack alignItems="stretch" flex="1" gap="18px" maxWidth="70vw">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The maxWidth was an attempt to solve this problem but was leading to the weird table width; the other props, as far as I can tell, didn't actually do anything.

<VStack alignItems="stretch">
<DataTabsContent
data={tabData}
index={tabIndex}
Expand Down