Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding a page describing the libraries #25

Open
wants to merge 2 commits into
base: gh-pages
Choose a base branch
from

Conversation

davewhiteland
Copy link
Contributor

For now, this is really most useful re: the everypolitician gem.

I've added Python examples too, but until we're ported everypolitician-popolo this is less useful.

My logic in having the duplicated Ruby/Python is that this is simplest; later we can collapse this intelligently in the browser with JS to allow language-based context in the single text. But as that doesn't exist yet, I propose it's better to duplicate.

@tmtmtmtm tmtmtmtm changed the base branch from gh-pages to fail-if-there-are-gemfile.lock-changes September 15, 2016 10:58
@tmtmtmtm tmtmtmtm changed the base branch from fail-if-there-are-gemfile.lock-changes to gh-pages September 15, 2016 10:59
@chrismytton chrismytton force-pushed the gh-pages-23-new-library-page branch from 47ef82f to 643bbf3 Compare September 15, 2016 11:39
@chrismytton
Copy link
Contributor

Rebased onto gh-pages.

@chrismytton chrismytton force-pushed the gh-pages-23-new-library-page branch from 643bbf3 to 00a8264 Compare September 16, 2016 08:54
@chrismytton
Copy link
Contributor

Rebased again onto latest gh-pages, hopefully this time the tests will be fixed!

@chrismytton
Copy link
Contributor

Looks like this is failing because External link http://docs.everypolitician.org/libraries.html failed: 404 No error, which makes sense since that page won't exist until this pull request is merged. So to fix this we need to either tell the external link checker to ignore docs.everypolitician.org, or we need to make html-proofer detect these links as internal rather than external.

@tmtmtmtm
Copy link
Contributor

I've extracted the first part of this out as #33 — there's no need to hold that up behind tweaks to the libraries.html page

@tmtmtmtm tmtmtmtm force-pushed the gh-pages-23-new-library-page branch from 00a8264 to accc9eb Compare January 5, 2017 09:56
@tmtmtmtm
Copy link
Contributor

tmtmtmtm commented Jan 5, 2017

I tried to rebase this over #33, but it dropped the key commit, so I reverted the earlier revert, which leaves the history a little odd, but with all the files intact again.

Dave Whiteland and others added 2 commits May 22, 2018 16:31
@tmtmtmtm tmtmtmtm force-pushed the gh-pages-23-new-library-page branch from df3aa70 to 28ca95e Compare May 22, 2018 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants