Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated test_configurations.go for new batch track #1157

Merged
merged 3 commits into from
Aug 21, 2024
Merged

Updated test_configurations.go for new batch track #1157

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
27119ad
Update test_configurations.go
GroophyLifefor Aug 20, 2024
d2ee595
Update test_configurations.go
GroophyLifefor Aug 20, 2024
5ea9a88
Merge branch 'main' into dev/batch
ErikSchierboom Aug 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions workspace/test_configurations.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ var TestConfigurations = map[string]TestConfiguration{
"ballerina": {
Command: "bal test",
},
// batch: batch test-runner disabled and focus solely on Windows.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't really have anything to do with the test runner, it is all about running things locally.
And we have a WindowsCommand option for Windows-specific commands:

cli/workspace/test_configurations.go

Line 157 in 27119ad

WindowsCommand: "gradlew.bat test",

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit confused about how this works.

In windows terminal I start batch files with call built-in command like

call main.bat

but in this case if we call test files, how can I validate path?

there a example but may not correct one.

"batch": {
  WindowsCommand: "call {{test_files}}",
},

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The command you listed will replace {{test_files}} with a space-separated list of all the test files, as defined in the .files.test key in the exercise's .meta/config.json file. E.g. if the student is working on the darts exercise, it would expand too: call DartsTest.bat (see https://github.com/exercism/batch/blob/main/exercises/practice/darts/.meta/config.json#L7-L9).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got it, wow, it's a huge ecosystem and everything can work in parallel 😄

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you now reReview?

"bash": {
Command: "bats {{test_files}}",
},
Expand Down
Loading