-
-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated test_configurations.go for new batch track #1157
Conversation
I'm not sure what you mean by this. The snippets are the bits of code (like summaries) that are shown on the website. They're not opt-into, every iteration has one created for them. |
workspace/test_configurations.go
Outdated
@@ -74,6 +74,7 @@ var TestConfigurations = map[string]TestConfiguration{ | |||
"ballerina": { | |||
Command: "bal test", | |||
}, | |||
// batch: batch test-runner disabled and focus solely on Windows. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't really have anything to do with the test runner, it is all about running things locally.
And we have a WindowsCommand
option for Windows-specific commands:
cli/workspace/test_configurations.go
Line 157 in 27119ad
WindowsCommand: "gradlew.bat test", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit confused about how this works.
In windows terminal I start batch files with call built-in command like
call main.bat
but in this case if we call test files, how can I validate path?
there a example but may not correct one.
"batch": {
WindowsCommand: "call {{test_files}}",
},
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The command you listed will replace {{test_files}}
with a space-separated list of all the test files, as defined in the .files.test
key in the exercise's .meta/config.json
file. E.g. if the student is working on the darts
exercise, it would expand too: call DartsTest.bat
(see https://github.com/exercism/batch/blob/main/exercises/practice/darts/.meta/config.json#L7-L9).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got it, wow, it's a huge ecosystem and everything can work in parallel 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you now reReview?
Ah, I thinked snippets which used in website code editor, okay. |
I think I have to leave it like this at this stage, because we only have the verify process. can you verify me @ErikSchierboom ?
LoC tool supports batch language,
and we don't generally use snippets in batch language.