Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a11y fix: header navigation landmark (primary navigation) #1848

Open
wants to merge 5 commits into
base: gh-pages
Choose a base branch
from

Conversation

ShubhamOulkar
Copy link
Member

close #1807

@ShubhamOulkar ShubhamOulkar requested review from a team as code owners March 26, 2025 14:03
Copy link

netlify bot commented Mar 26, 2025

Deploy Preview for expressjscom-preview ready!

Name Link
🔨 Latest commit ca7e3bd
🔍 Latest deploy log https://app.netlify.com/sites/expressjscom-preview/deploys/67f5be8b31bb7c00087426ee
😎 Deploy Preview https://deploy-preview-1848--expressjscom-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bjohansebas
Copy link
Member

This is no longer working.
image
https://deploy-preview-1848--expressjscom-preview.netlify.app/ru/

Try switching between languages multiple times.

@bjohansebas bjohansebas added the a11y / accessibility Issues concerning accessibility label Mar 30, 2025
@ShubhamOulkar
Copy link
Member Author

Fixed issue from #1848 (comment) in 771de1a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y / accessibility Issues concerning accessibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure Each HTML Document Has One Main Landmark and Contains All Page Content Within Landmarks
2 participants