Skip to content

a11y fix: header navigation landmark (primary navigation) #1848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 17, 2025
Merged

a11y fix: header navigation landmark (primary navigation) #1848

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
348defa
add primary navigation landmark
ShubhamOulkar Mar 26, 2025
ff457ed
fix layout of home page
ShubhamOulkar Mar 26, 2025
771de1a
update translation home pages
ShubhamOulkar Mar 30, 2025
51422ab
Merge branch 'gh-pages' into primary-navigation
ShubhamOulkar Apr 6, 2025
ca7e3bd
Merge branch 'gh-pages' into primary-navigation
ShubhamOulkar Apr 9, 2025
8a38c87
Merge branch 'gh-pages' into primary-navigation
bjohansebas Apr 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions _includes/header.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
<img src="/images/brand/logotype-dark.svg" alt="Express.js logo" width="90" height="30"/>
</a>
</div>
<div id="navbar">
<nav id="navbar" aria-label="primary">
<input id="q" placeholder="🔎 search">
<ul id="navmenu">
<li>
Expand Down Expand Up @@ -246,7 +246,7 @@
</ul>
</li>
</ul>
</div>
</nav>
<div class="header-right">
<button id="theme-toggle" type="button" class="theme-btn" title="change theme">
<i class="fa fa-moon-o fa-2x hidden-dark"></i>
Expand Down
13 changes: 10 additions & 3 deletions _layouts/home.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,18 @@
<body class="en-doc">
{% else %}
<body class="non-en-doc">
<div id="i18n-notice-box" class="doc-box doc-notice">
{% include i18n-notice.html %}
</div>
{% endif %}

{% include header.html %}

<div id="overlay"></div>

{% if page.lang != 'en' %}
<div id="i18n-notice-box" class="doc-box doc-notice">
{% include i18n-notice.html %}
</div>
{% endif %}

<main class="home">
{{ content }}
</main>
Expand Down
2 changes: 0 additions & 2 deletions de/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ menu: home
lang: de
---
<section id="home-content">
{% include header.html %}
<div id="overlay"></div>
<div id="homepage-leftpane" class="pane">
<section id="description">
<div class="express"><a href="/">Express</a></div>
Expand Down
2 changes: 0 additions & 2 deletions es/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ description: Express is a fast, unopinionated, minimalist web framework for Node
providing a robust set of features for web and mobile applications.
---
<section id="home-content">
{% include header.html %}
<div id="overlay"></div>
<div id="homepage-leftpane" class="pane">
<section id="description">
<div class="express"><a href="/">Express</a></div>
Expand Down
2 changes: 0 additions & 2 deletions fr/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ description: Express is a fast, unopinionated, minimalist web framework for Node
providing a robust set of features for web and mobile applications.
---
<section id="home-content">
{% include header.html %}
<div id="overlay"></div>
<div id="homepage-leftpane" class="pane">
<section id="description">
<div class="express"><a href="/">Express</a></div>
Expand Down
2 changes: 0 additions & 2 deletions id/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ description: Express is a fast, unopinionated, minimalist web framework for Node
providing a robust set of features for web and mobile applications.
---
<section id="home-content">
{% include header.html %}
<div id="overlay"></div>
<div id="homepage-leftpane" class="pane">
<section id="description">
<div class="express"><a href="/">Express</a><a href="{{ page.lang }}/changelog/4x.html#{{ site.data.express.current_version }}" id="express-version">{{ site.data.express.current_version }}</a></div>
Expand Down
2 changes: 0 additions & 2 deletions index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@ redirect_from: "/en/index.html"
---

<section id="home-content">
{% include header.html %}
<div id="overlay"></div>
<div id="homepage-leftpane" class="pane">
<section id="description">
<div class="express"><a href="/">Express</a><a href="{{ page.lang }}/changelog/4x.html#{{ site.data.express.current_version }}" id="express-version">{{ site.data.express.current_version }}</a></div>
Expand Down
2 changes: 0 additions & 2 deletions it/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ description: Express is a fast, unopinionated, minimalist web framework for Node
providing a robust set of features for web and mobile applications.
---
<section id="home-content">
{% include header.html %}
<div id="overlay"></div>
<div id="homepage-leftpane" class="pane">
<section id="description">
<div class="express"><a href="/">Express</a></div>
Expand Down
2 changes: 0 additions & 2 deletions ja/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@ description: Express is a fast, unopinionated, minimalist web framework for Node
---

<section id="home-content">
{% include header.html %}
<div id="overlay"></div>
<div id="homepage-leftpane" class="pane">
<section id="description">
<div class="express"><a href="/">Express</a></div>
Expand Down
2 changes: 0 additions & 2 deletions ko/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ description: Express is a fast, unopinionated, minimalist web framework for Node
providing a robust set of features for web and mobile applications.
---
<section id="home-content">
{% include header.html %}
<div id="overlay"></div>
<div id="homepage-leftpane" class="pane">
<section id="description">
<div class="express"><a href="/">Express</a><a href="changelog/4x.html#{{ site.data.express.current_version }}" id="express-version">{{ site.data.express.current_version }}</a></div>
Expand Down
2 changes: 0 additions & 2 deletions pt-br/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ description: Express is a fast, unopinionated, minimalist web framework for Node
providing a robust set of features for web and mobile applications.
---
<section id="home-content">
{% include header.html %}
<div id="overlay"></div>
<div id="homepage-leftpane" class="pane">
<section id="description">
<div class="express"><a href="/">Express</a><a href="{{ page.lang }}/changelog/4x.html#{{ site.data.express.current_version }}" id="express-version">{{ site.data.express.current_version }}</a></div>
Expand Down
2 changes: 0 additions & 2 deletions ru/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ description: Express is a fast, unopinionated, minimalist web framework for Node
providing a robust set of features for web and mobile applications.
---
<section id="home-content">
{% include header.html %}
<div id="overlay"></div>
<div id="homepage-leftpane" class="pane">
<section id="description">
<div class="express"><a href="/">Express</a></div>
Expand Down
2 changes: 0 additions & 2 deletions sk/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@ description: Express is a fast, unopinionated, minimalist web framework for Node
---

<section id="home-content">
{% include header.html %}
<div id="overlay"></div>
<div id="homepage-leftpane" class="pane">
<section id="description">
<div class="express"><a href="/">Express</a></div>
Expand Down
2 changes: 0 additions & 2 deletions th/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ description: Express is a fast, unopinionated, minimalist web framework for Node
providing a robust set of features for web and mobile applications.
---
<section id="home-content">
{% include header.html %}
<div id="overlay"></div>
<div id="homepage-leftpane" class="pane">
<section id="description">
<div class="express"><a href="/">Express</a><a href="{{ page.lang }}/changelog/4x.html#{{ site.data.express.current_version }}" id="express-version">{{ site.data.express.current_version }}</a></div>
Expand Down
2 changes: 0 additions & 2 deletions tr/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ description: Express is a fast, unopinionated, minimalist web framework for Node
providing a robust set of features for web and mobile applications.
---
<section id="home-content">
{% include header.html %}
<div id="overlay"></div>
<div id="homepage-leftpane" class="pane">
<section id="description">
<div class="express"><a href="/">Express</a><a href="{{ page.lang }}/changelog/4x.html#{{ site.data.express.current_version }}" id="express-version">{{ site.data.express.current_version }}</a></div>
Expand Down
2 changes: 0 additions & 2 deletions uk/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ description: Express is a fast, unopinionated, minimalist web framework for Node
providing a robust set of features for web and mobile applications.
---
<section id="home-content">
{% include header.html %}
<div id="overlay"></div>
<div id="homepage-leftpane" class="pane">
<section id="description">
<div class="express"><a href="/">Express</a></div>
Expand Down
2 changes: 0 additions & 2 deletions uz/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ description: Express is a fast, unopinionated, minimalist web framework for Node
providing a robust set of features for web and mobile applications.
---
<section id="home-content">
{% include header.html %}
<div id="overlay"></div>
<div id="homepage-leftpane" class="pane">
<section id="description">
<div class="express"><a href="/">Express</a></div>
Expand Down
2 changes: 0 additions & 2 deletions zh-cn/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ description: Express is a fast, unopinionated, minimalist web framework for Node
providing a robust set of features for web and mobile applications.
---
<section id="home-content">
{% include header.html %}
<div id="overlay"></div>
<div id="homepage-leftpane" class="pane">
<section id="description">
<div class="express"><a href="/">Express</a></div>
Expand Down
2 changes: 0 additions & 2 deletions zh-tw/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ description: Express is a fast, unopinionated, minimalist web framework for Node
providing a robust set of features for web and mobile applications.
---
<section id="home-content">
{% include header.html %}
<div id="overlay"></div>
<div id="homepage-leftpane" class="pane">
<section id="description">
<div class="express"><a href="/">Express</a></div>
Expand Down
Loading