Change template file to reflect dev cluster url and port #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and BAYESIAN_GREMLIN_HTTPINGESTION_SERVICE_PORT The current values point to localhost instance and failing for dev cluster deployments. Since now we have dev cluster as our primary playground, I am changing the variables to reflect the same.
|
[test] |
1 similar comment
|
[test] |
Open
msrb
reviewed
Mar 14, 2018
| host=os.environ.get("BAYESIAN_GREMLIN_HTTPINGESTION_SERVICE_HOST", "localhost"), | ||
| port=os.environ.get("BAYESIAN_GREMLIN_HTTPINGESTION_SERVICE_PORT", "8181")) | ||
| host=os.environ.get("BAYESIAN_GREMLIN_HTTPINGESTION_SERVICE_HOST", "bayesian-gremlin-http"), | ||
| port=os.environ.get("BAYESIAN_GREMLIN_HTTPINGESTION_SERVICE_PORT", "8182")) |
There was a problem hiding this comment.
It's weird that this is failing for dev cluster deployments as both variables (BAYESIAN_GREMLIN_HTTPINGESTION_SERVICE_HOST and BAYESIAN_GREMLIN_HTTPINGESTION_SERVICE_PORT) should be provided by OpenShift/k8s automatically. The only case when I would expect those variables to be missing is when data-importer was deployed sooner then gremlin. In such case, OpenShift would not know about the service and those variables would be missing.
@abs51295 is this issue reproducible?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change default values for BAYESIAN_GREMLIN_HTTPINGESTION_SERVICE_HOST and BAYESIAN_GREMLIN_HTTPINGESTION_SERVICE_PORT
The current values point to localhost instance and failing for dev cluster deployments. Since now we have dev cluster as our primary playground, I am changing the variables to reflect the same.