Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change template file to reflect dev cluster url and port #120

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/config.py.template
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ LOGFILE_PATH = os.environ.get("LOGFILE_PATH", "/tmp/error.log")
_gremlin_securely = "true" == os.environ.get("GREMLIN_USE_SECURE_CONNECTION", "false").lower()
GREMLIN_SERVER_URL_REST = "{proto}://{host}:{port}".format(
proto="https" if _gremlin_securely else "http",
host=os.environ.get("BAYESIAN_GREMLIN_HTTPINGESTION_SERVICE_HOST", "localhost"),
port=os.environ.get("BAYESIAN_GREMLIN_HTTPINGESTION_SERVICE_PORT", "8181"))
host=os.environ.get("BAYESIAN_GREMLIN_HTTPINGESTION_SERVICE_HOST", "bayesian-gremlin-http"),
port=os.environ.get("BAYESIAN_GREMLIN_HTTPINGESTION_SERVICE_PORT", "8182"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's weird that this is failing for dev cluster deployments as both variables (BAYESIAN_GREMLIN_HTTPINGESTION_SERVICE_HOST and BAYESIAN_GREMLIN_HTTPINGESTION_SERVICE_PORT) should be provided by OpenShift/k8s automatically. The only case when I would expect those variables to be missing is when data-importer was deployed sooner then gremlin. In such case, OpenShift would not know about the service and those variables would be missing.

@abs51295 is this issue reproducible?


# To load data from S3
AWS_S3_ACCESS_KEY_ID = os.environ.get("AWS_S3_ACCESS_KEY_ID", "")
Expand Down