Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump com.fasterxml.jackson:jackson-bom from 2.15.3 to 2.16.0 #5595

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 16, 2023

Bumps com.fasterxml.jackson:jackson-bom from 2.15.3 to 2.16.0.

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Nov 16, 2023
@dependabot dependabot bot requested a review from shawkins as a code owner November 16, 2023 11:09
@dependabot dependabot bot added the java Pull requests that update Java code label Nov 16, 2023
@dependabot dependabot bot requested a review from sunix as a code owner November 16, 2023 11:09
@rohanKanojia
Copy link
Member

Karaf tests failing:

[INFO] Results:
[INFO] 
Error:  Errors: 
Error:    FeatureInstallationTest.testKubernetesClientFeature » Reason Unable to resolve com.fasterxml.jackson.dataformat.jackson-dataformat-yaml/2.16.0: missing requirement [com.fasterxml.jackson.dataformat.jackson-dataformat-yaml/2.16.0] osgi.wiring.package; filter:="(&(osgi.wiring.package=org.yaml.snakeyaml)(version>=2.2.0)(!(version>=3.0.0)))"
Error:    FeatureInstallationTest.testOpenshiftClient » Reason Unable to resolve com.fasterxml.jackson.dataformat.jackson-dataformat-yaml/2.16.0: missing requirement [com.fasterxml.jackson.dataformat.jackson-dataformat-yaml/2.16.0] osgi.wiring.package; filter:="(&(osgi.wiring.package=org.yaml.snakeyaml)(version>=2.2.0)(!(version>=3.0.0)))"
Error:  io.fabric8.kubernetes.karaf.itests.KubernetesDeserializerTest.null
Error:    Run 1: KubernetesDeserializerTest » Runtime Problem starting container
Error:    Run 2: KubernetesDeserializerTest » Runtime Container never came up
[INFO] 
Error:  io.fabric8.kubernetes.karaf.itests.PropertiesOverrideTest.null
Error:    Run 1: PropertiesOverrideTest » Runtime Cannot get the remote bundle context
Error:    Run 2: PropertiesOverrideTest » Runtime Container never came up
[INFO] 
Error:  io.fabric8.kubernetes.karaf.itests.ServiceTest.null
Error:    Run 1: ServiceTest » Runtime Problem starting container
Error:    Run 2: ServiceTest » Runtime Container never came up
[INFO] 
[INFO] 
Error:  Tests run: 5, Failures: 0, Errors: 5, Skipped: 0
[INFO] 
[INFO] ------------------------------------------------------------------------

@rohanKanojia rohanKanojia force-pushed the dependabot/maven/com.fasterxml.jackson-jackson-bom-2.16.0 branch 2 times, most recently from 5602039 to 19ba9f9 Compare December 22, 2023 17:21
@rohanKanojia
Copy link
Member

rohanKanojia commented Dec 22, 2023

After update to jackson 2.16.0, AdaptTest seems to be failing with this error:

Caused by: com.fasterxml.jackson.databind.exc.InvalidDefinitionException: Java 8 optional type `java.util.Optional<io.fabric8.kubernetes.api.builder.VisitableMap>` not supported by default: add Module "com.fasterxml.jackson.datatype:jackson-datatype-jdk8" to enable handling (through reference chain: io.fabric8.kubernetes.api.model.APIGroupListBuilder["_visitables"]->io.fabric8.kubernetes.api.builder.VisitableMap["groups"]->java.util.ArrayList[0]->io.fabric8.kubernetes.api.model.APIGroupBuilder["visitableMap"])

On closer look, it looks like jackson is rightly pointing out that code is problematic (it's missing .build() for List builder)

server.expect().withPath("/apis").andReturn(HttpURLConnection.HTTP_OK, new APIGroupListBuilder()
.addToGroups(new APIGroupBuilder().withName("security.internal.openshift.io").build()))

Copy link
Contributor Author

dependabot bot commented on behalf of github Dec 25, 2023

A newer version of com.fasterxml.jackson:jackson-bom exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@rohanKanojia rohanKanojia changed the title chore(deps): bump com.fasterxml.jackson:jackson-bom from 2.15.3 to 2.16.0 chore(deps): bump com.fasterxml.jackson:jackson-bom from 2.15.3 to 2.16.1 Dec 26, 2023
@rohanKanojia rohanKanojia force-pushed the dependabot/maven/com.fasterxml.jackson-jackson-bom-2.16.0 branch from 03860a6 to 9d7e0e4 Compare December 26, 2023 10:00
@rohanKanojia
Copy link
Member

A newer version of com.fasterxml.jackson:jackson-bom exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is me

I saw a new patch release of jackson v2.16.1 and thought of bumping jackson to this version.

However, bumping to jackson v2.16.1 seems to be causing SimpleIT.tasks_javaCompilationIsSuccessfulAfterCrd2Java to fail

Error:  Tests run: 3, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 17.45 s <<< FAILURE! -- in io.fabric8.java.generator.gradle.plugin.SimpleIT
Error:  io.fabric8.java.generator.gradle.plugin.SimpleIT.tasks_containsJavaGeneratorTasks -- Time elapsed: 16.04 s <<< ERROR!
org.gradle.testkit.runner.UnexpectedBuildFailure: 
Unexpected build execution failure in /home/runner/work/kubernetes-client/kubernetes-client/java-generator/it/src/it/plugin/gradle/simple with arguments [-PkubernetesClientVersion=6.10-SNAPSHOT, --console=plain, tasks, --all, --stacktrace]

Output:

FAILURE: Build failed with an exception.

* Exception is:
org.gradle.api.ProjectConfigurationException: A problem occurred configuring root project 'gradle-simple-example'.

Caused by: java.lang.IllegalArgumentException: Unsupported class file major version 65
        at org.objectweb.asm.ClassReader.<init>(ClassReader.java:199)
        at org.objectweb.asm.ClassReader.<init>(ClassReader.java:180)
        at org.objectweb.asm.ClassReader.<init>(ClassReader.java:166)
        at org.gradle.internal.classpath.InstrumentingClasspathFileTransformer.lambda$visitEntries$1(InstrumentingClasspathFileTransformer.java:207)
        ... 15 more

If I build this on JDK21 it seems to pass.

@manusa
Copy link
Member

manusa commented Jan 2, 2024

io.fabric8.java.generator.gradle.plugin.SimpleIT.tasks_containsJavaGeneratorTasks

Is it only this test what fails? it's kind of odd that just because of this IT we need to bump the JDK version.

dependabot bot and others added 3 commits January 2, 2024 15:18
Bumps [com.fasterxml.jackson:jackson-bom](https://github.com/FasterXML/jackson-bom) from 2.15.3 to 2.16.0.
- [Commits](FasterXML/jackson-bom@jackson-bom-2.15.3...jackson-bom-2.16.0)

---
updated-dependencies:
- dependency-name: com.fasterxml.jackson:jackson-bom
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
…er in mockserver expectation

Signed-off-by: Rohan Kumar <[email protected]>
@rohanKanojia rohanKanojia force-pushed the dependabot/maven/com.fasterxml.jackson-jackson-bom-2.16.0 branch from 9d7e0e4 to 432f1c4 Compare January 2, 2024 09:48
Copy link

sonarqubecloud bot commented Jan 2, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@rohanKanojia rohanKanojia changed the title chore(deps): bump com.fasterxml.jackson:jackson-bom from 2.15.3 to 2.16.1 chore(deps): bump com.fasterxml.jackson:jackson-bom from 2.15.3 to 2.16.0 Jan 2, 2024
@manusa manusa merged commit dd33d95 into main Jan 2, 2024
17 of 19 checks passed
@manusa manusa deleted the dependabot/maven/com.fasterxml.jackson-jackson-bom-2.16.0 branch January 2, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants