misc: Surface clear parsing error for invalid prestopage header #11552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D66003722 |
✅ Deploy Preview for meta-velox canceled.
|
aozturk
force-pushed
the
export-D66003722
branch
from
c724ac5
to
07cfd2b
Compare
aozturk
pushed a commit
to aozturk/velox
that referenced
this pull request
Nov 18, 2024
…bookincubator#11552) Summary: During deserialization, PrestoPage header is parsed with the assumption of enough bytes in the provided input stream. This causes exceptions that are not easy to interpret when there is invalid data provided. This change validates existence of enough bytes before parsing the header and surfaces the parsing error with a clear exception message. Reviewed By: kevinwilfong Differential Revision: D66003722
|
This pull request was exported from Phabricator. Differential Revision: D66003722 |
aozturk
pushed a commit
to aozturk/velox
that referenced
this pull request
Nov 18, 2024
…bookincubator#11552) Summary: During deserialization, PrestoPage header is parsed with the assumption of enough bytes in the provided input stream. This causes exceptions that are not easy to interpret when there is invalid data provided. This change validates existence of enough bytes before parsing the header and surfaces the parsing error with a clear exception message. Reviewed By: kevinwilfong Differential Revision: D66003722
aozturk
force-pushed
the
export-D66003722
branch
from
07cfd2b
to
3584bc3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66003722 |
aozturk
pushed a commit
to aozturk/velox
that referenced
this pull request
Nov 18, 2024
…bookincubator#11552) Summary: During deserialization, PrestoPage header is parsed with the assumption of enough bytes in the provided input stream. This causes exceptions that are not easy to interpret when there is invalid data provided. This change validates existence of enough bytes before parsing the header and surfaces the parsing error with a clear exception message. Reviewed By: kevinwilfong Differential Revision: D66003722
aozturk
force-pushed
the
export-D66003722
branch
from
3584bc3
to
e8d3252
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66003722 |
aozturk
changed the title
|
This pull request was exported from Phabricator. Differential Revision: D66003722 |
…bookincubator#11552) Summary: During deserialization, PrestoPage header is parsed with the assumption of enough bytes in the provided input stream. This causes exceptions that are not easy to interpret when there is invalid data provided. This change validates existence of enough bytes before parsing the header and surfaces the parsing error with a clear exception message. Reviewed By: kevinwilfong Differential Revision: D66003722
aozturk
force-pushed
the
export-D66003722
branch
from
e8d3252
to
f85189e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66003722 |
|
This pull request has been merged in f5c7e4a. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: During deserialization, PrestoPage header is parsed with the assumption of enough bytes in the provided input stream. This causes exceptions that are not easy to interpret when there is invalid data provided. This change validates existence of enough bytes before parsing the header and surfaces the parsing error with a clear exception message.
Differential Revision: D66003722