Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc: Surface clear parsing error for invalid prestopage header #11552

Closed
wants to merge 1 commit into from
Closed

misc: Surface clear parsing error for invalid prestopage header #11552

wants to merge 1 commit into from

Commits on Nov 19, 2024

  1. misc: Surface clear parsing error for invalid prestopage header (face… 

    …bookincubator#11552)

Summary:

During deserialization, PrestoPage header is parsed with the assumption of enough bytes in the provided input stream. This causes exceptions that are not easy to interpret when there is invalid data provided. This change validates existence of enough bytes before parsing the header and surfaces the parsing error with a clear exception message.

Reviewed By: kevinwilfong

Differential Revision: D66003722
    @facebook-github-bot
    Abdullah Ozturk authored and facebook-github-bot committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    f85189e View commit details
    Browse the repository at this point in the history