improvement: make method more scalable

factorialco · Dec 5, 2024 · 18f3437 · 18f3437
1 parent 5ec9070
commit 18f3437
Showing 1 changed file with 10 additions and 1 deletion.
diff --git a/lib/resource_registry/registry.rb b/lib/resource_registry/registry.rb
@@ -49,7 +49,7 @@ def fetch!(identifier)
       ).returns(T.nilable(Resource))
     end
     def fetch_for_repository(repository_class)
-      fetch_all.values.find { |r| r.repository_raw == repository_class.to_s }
+      resources_by_raw_repository[repository_class.to_s]
     end
 
     alias find_for_repository fetch_for_repository
@@ -78,6 +78,15 @@ def fetch_with_capabilities(*capabilities)
     sig { returns(T::Hash[String, Resource]) }
     attr_accessor :resources
 
+    sig { returns(T::Hash[String, Resource]) }
+    def resources_by_raw_repository
+      @resources_by_raw_repository ||=
+        T.let(
+          resources.values.index_by(&:repository_raw),
+          T.nilable(T::Hash[String, Resource])
+        )
+    end
+
     sig { params(resources: T::Array[Resource]).returns(T::Boolean) }
     def duplicated_identifier?(resources)
       resources.map(&:identifier).uniq.size != resources.size