Improve fetch_for_repository
performance
#28
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
Resource#repository
produces a call tosafe_constantize
on therepository_raw
string. Such calls are expensive because they trigger a loading cascade of other constants. In this case, it's also unnecessary since you can find repositories by comparing the strings directly, so we bypass the need for it completely.We've also made the method more scalable for successive calls by creating an appropriate hash index for direct
repository_raw
lookups.