Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve fetch_for_repository performance #28

Merged
merged 2 commits into from
Dec 5, 2024
Merged

Improve fetch_for_repository performance #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ec9070
fix: improve `fetch_for_repository` performance by preventing reposit…
jacobobq Dec 5, 2024
18f3437
improvement: make method more scalable
jacobobq Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 13 additions & 11 deletions lib/resource_registry/registry.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# typed: strict
# frozen_string_literal: true
# typed: false

require_relative "resource"
require_relative "capabilities/capability_config"
Expand Down Expand Up @@ -49,9 +49,11 @@ def fetch!(identifier)
).returns(T.nilable(Resource))
end
def fetch_for_repository(repository_class)
fetch_all.values.find { |r| r.repository == repository_class }
resources_by_raw_repository[repository_class.to_s]
end

alias find_for_repository fetch_for_repository

sig { returns(T::Hash[String, Resource]) }
def fetch_all
resources
Expand All @@ -71,20 +73,20 @@ def fetch_with_capabilities(*capabilities)
end
end

sig do
params(
repository: T::Class[ResourceRegistry::Repositories::Base[T.untyped]]
).returns(T.nilable(Resource))
end
def find_by_repository(repository)
fetch_all.values.find { |resource| resource.repository == repository }
end

private

sig { returns(T::Hash[String, Resource]) }
attr_accessor :resources

sig { returns(T::Hash[String, Resource]) }
def resources_by_raw_repository
@resources_by_raw_repository ||=
T.let(
resources.values.index_by(&:repository_raw),
T.nilable(T::Hash[String, Resource])
)
end

sig { params(resources: T::Array[Resource]).returns(T::Boolean) }
def duplicated_identifier?(resources)
resources.map(&:identifier).uniq.size != resources.size
Expand Down
2 changes: 1 addition & 1 deletion lib/resource_registry/resource.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ def verbs_except(except)
def dump
{
"identifier" => identifier,
"repository" => repository.to_s,
"repository" => repository_raw,
"description" => description,
"relationships" => relationships.values.map(&:dump),
"capabilities" =>
Expand Down
Loading