-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix (replicator): Backfill Reactions and Storage Tables #1589
Conversation
This reverts commit 605363e.
backfillFidStorageAllocations jobs
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1589 +/- ##
==========================================
- Coverage 73.34% 73.27% -0.07%
==========================================
Files 92 92
Lines 8636 8636
Branches 1946 1946
==========================================
- Hits 6334 6328 -6
- Misses 2184 2190 +6
Partials 118 118 ☔ View full report in Codecov by Sentry. |
Thank you! |
Merged your change with an additional modification in #1592. |
Motivation
In its current implementation the replicator does not backfill the
storage_allocations
orreactions
table. This PR adds logic to do thatChange Summary
BackfillFidStorageAllocations
jobBackfillFidOtherOnChainEvents
as it's now getting added to thechain_events
table throughprocessOnChainEvents
BackfillFidReactions
to theBackfillFidData
jobMerge Checklist
Choose all relevant options below by adding an
x
now or at any time before submitting for reviewAdditional Context
Adding these two backfill jobs increases the backfill time significantly. We should add the ability to bootstrap the replicator from a snapshot like hubble
PR-Codex overview
This PR focuses on backfilling various data for a given fid.
Detailed summary
backfillFidOtherOnChainEvents.ts
:OnChainEventType.EVENT_TYPE_STORAGE_RENT
fromeventTypes
array.idRegisterEventTypes
array.backfillFidStorageAllocations.ts
:OnChainEventType
,getOnChainEventsByFidInBatchesOf
,registerJob
, andprocessOnChainEvents
.BackfillFidStorageAllocations
as a registered job.run
method that backfills storage allocations for a given fid.backfillFidData.ts
:BackfillFidReactions
andBackfillFidStorageAllocations
.