Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

context.py:117-121: Move context realization to pure to... #183

Closed
0pdd opened this issue Sep 17, 2018 · 9 comments
Closed

context.py:117-121: Move context realization to pure to... #183

0pdd opened this issue Sep 17, 2018 · 9 comments
Assignees
@ArtemijRodionov
Labels
1 burning issue 2 hours some big and monolith issues. For example with hard decisions or discussions cleanup everything that do project stronger, flexible, reusable Context feature report Put it to completed tasks temporary list for business Tags STB's feature

Comments

@0pdd
Copy link
Collaborator

0pdd commented Sep 17, 2018

The puzzle 550-c08f412e from #550 has to be resolved:

refarm-site/catalog/context.py

Lines 117 to 121 in 471fe2d

# @todo #550:120m Move context realization to pure to objects composition.
# Discussed some thoughts with Artemiy via call.
# Artemiy will do it.
# For example SortedCategory should
# consist of separated SortedList and Category classes/objects.

The puzzle was created by duker33 on 17-Sep-18.

Estimate: 120 minutes,

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
0pdd referenced this issue Sep 17, 2018
@duker33
se#577 Move context module to refarm.catalog app (#180)
471fe2d
@duker33 duker33 mentioned this issue Sep 20, 2018
Closed
@duker33 duker33 added 2 hours some big and monolith issues. For example with hard decisions or discussions 1 burning issue cleanup everything that do project stronger, flexible, reusable Tags STB's feature labels Sep 20, 2018
@duker33
Copy link
Collaborator

duker33 commented Oct 1, 2018

search #183 at all project's code. Many places are needed in this refactor

@ArtemijRodionov ArtemijRodionov mentioned this issue Oct 8, 2018
Merged
ArtemijRodionov added a commit that referenced this issue Nov 4, 2018
@ArtemijRodionov
#183 object compositions (#194)
fb2fa2a 
* Create catalog.context package

* Create context package

* Specify context ABS classes

* Implement base product contexts classes

* Implement base tag contexts classes

* Resolve todo and create another one for  ordering arg

* Self-review fixes

* Review fixes

* Self-review fixes
This was referenced Nov 4, 2018
Closed
Closed
@0pdd
Copy link
Collaborator Author

0pdd commented Nov 4, 2018

@0pdd 2 puzzles #207, #208 are still not solved.

@ArtemijRodionov ArtemijRodionov added the report Put it to completed tasks temporary list for business label Nov 4, 2018
@0pdd
Copy link
Collaborator Author

0pdd commented Nov 13, 2018

@0pdd 2 puzzles #208, #213 are still not solved; solved: #207.

@0pdd
Copy link
Collaborator Author

0pdd commented Nov 16, 2018

@0pdd the puzzle #213 is still not solved; solved: #207, #208.

@ArtemijRodionov ArtemijRodionov mentioned this issue Dec 30, 2018
Closed
@duker33 duker33 added the Context feature label Dec 31, 2018
@0pdd
Copy link
Collaborator Author

0pdd commented Dec 31, 2018

@0pdd 3 puzzles #239, #240, #241 are still not solved; solved: #207, #208, #213.

@0pdd
Copy link
Collaborator Author

0pdd commented Feb 14, 2019

@0pdd 6 puzzles #239, #240, #241, #267, #268, #269 are still not solved; solved: #207, #208, #213.

@0pdd
Copy link
Collaborator Author

0pdd commented Mar 15, 2019

@0pdd 4 puzzles #239, #267, #268, #269 are still not solved; solved: #207, #208, #213, #240, #241.

@0pdd
Copy link
Collaborator Author

0pdd commented Mar 16, 2019

@0pdd 3 puzzles #239, #268, #269 are still not solved; solved: #207, #208, #213, #240, #241, #267.

@0pdd
Copy link
Collaborator Author

0pdd commented Apr 3, 2019

@0pdd 2 puzzles #239, #269 are still not solved; solved: #207, #208, #213, #240, #241, #267, #268.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ArtemijRodionov ArtemijRodionov

Labels
1 burning issue 2 hours some big and monolith issues. For example with hard decisions or discussions cleanup everything that do project stronger, flexible, reusable Context feature report Put it to completed tasks temporary list for business Tags STB's feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@duker33 @ArtemijRodionov @0pdd