Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

__init__.py:1: Implement Page, PaginatedProducts context... #213

Closed
0pdd opened this issue Nov 13, 2018 · 1 comment
Closed

__init__.py:1: Implement Page, PaginatedProducts context... #213

0pdd opened this issue Nov 13, 2018 · 1 comment
Assignees
@ArtemijRodionov
Labels
1 burning issue 2 hours some big and monolith issues. For example with hard decisions or discussions cleanup everything that do project stronger, flexible, reusable Context feature report Put it to completed tasks temporary list for business

Comments

@0pdd
Copy link
Collaborator

0pdd commented Nov 13, 2018

The puzzle 207-854acb10 from #207 has to be resolved:

refarm-site/catalog/newcontext/__init__.py

Line 1 in 4b333aa

# @todo #207:120m Implement Page, PaginatedProducts context classes.

The puzzle was created by Artemiy on 13-Nov-18.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
0pdd referenced this issue Nov 13, 2018
@ArtemijRodionov
#207 Context classes (#212)
4b333aa 
* Implement ProductBrands class

* Implement ProductImages class

* Create tests: ProductsContext and TagsContext. Fix a lot of code.

* Apply the review's fixes
This was referenced Nov 13, 2018
Closed
Closed
@ArtemijRodionov ArtemijRodionov added 2 hours some big and monolith issues. For example with hard decisions or discussions 1 burning issue cleanup everything that do project stronger, flexible, reusable labels Nov 13, 2018
@ArtemijRodionov ArtemijRodionov self-assigned this Nov 13, 2018
@ArtemijRodionov ArtemijRodionov mentioned this issue Dec 30, 2018
Merged
@duker33 duker33 added the Context feature label Dec 31, 2018
ArtemijRodionov added a commit that referenced this issue Dec 31, 2018
@ArtemijRodionov
#213 paginated products (#238)
11231f5 
* Create PaginatedProducts, fix some roughness.

* Create todo for mocked Context

* Create todo for Page context class

* Self-review fixes

* Apply review fixes

* Apply review-fixes #2
@0pdd 0pdd mentioned this issue Dec 31, 2018
Open
@ArtemijRodionov ArtemijRodionov added the report Put it to completed tasks temporary list for business label Dec 31, 2018
@0pdd
Copy link
Collaborator Author

0pdd commented Dec 31, 2018

@0pdd the puzzle #239 is still not solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ArtemijRodionov ArtemijRodionov

Labels
1 burning issue 2 hours some big and monolith issues. For example with hard decisions or discussions cleanup everything that do project stronger, flexible, reusable Context feature report Put it to completed tasks temporary list for business
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@duker33 @ArtemijRodionov @0pdd