Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

analytics_goals.py:5: Implement GoogleEcommerceGoals and... #940

Open
0pdd opened this issue Jul 5, 2019 · 2 comments
Open

analytics_goals.py:5: Implement GoogleEcommerceGoals and... #940

0pdd opened this issue Jul 5, 2019 · 2 comments
Assignees
@ArtemijRodionov
Labels
3 we can defer this issue. But it'll good to implement it 30 mins middle-sized issue. Usually a part of feature or a fix cleanup everything that do project stronger, flexible, reusable front markup or work with js Metrics feature about business metrics

Comments

@0pdd
Copy link
Collaborator

0pdd commented Jul 5, 2019

The puzzle 929-26614c74 from #929 has to be resolved:

shopelectro/shopelectro/selenium/analytics_goals.py

Line 5 in 63a1de7

# @todo #929:30m Implement GoogleEcommerceGoals and YandexMetrikaGoals and use them in tests.

The puzzle was created by Artemiy on 05-Jul-19.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
@0pdd
Copy link
Collaborator Author

0pdd commented Jul 5, 2019

@artemiyds2 @duker33 please pay attention to this new issue.

0pdd referenced this issue Jul 5, 2019
@ArtemijRodionov
#929 ecommerce goals for tests (#933)
63a1de7 
* Create SiteDriver.delete_session method

* Create Goals interface for selenium tests

* Use the YandexEcommerceGoals in tests

* Review fixes

* Make rebase to master

* Apply linter rules
This was referenced Jul 5, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@ArtemijRodionov ArtemijRodionov added 3 we can defer this issue. But it'll good to implement it cleanup everything that do project stronger, flexible, reusable take it any teammate can take this issue and start working with it 30 mins middle-sized issue. Usually a part of feature or a fix labels Jul 5, 2019
@ArtemijRodionov ArtemijRodionov self-assigned this Jul 5, 2019
@ArtemijRodionov ArtemijRodionov removed the take it any teammate can take this issue and start working with it label Jul 5, 2019
@duker33 duker33 added front markup or work with js Metrics feature about business metrics labels Jul 5, 2019
@duker33
Copy link
Contributor

duker33 commented Jul 10, 2019

dicts structure with goals contents look like some Jedi knowledge. We should provide clear interface for it.
Yes, shopelectro.selenium.analytics_goals.YandexEcommerceGoals contains link on the doc with structure. But it can't type checked and not as clear as our interface

@duker33 duker33 mentioned this issue Jul 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ArtemijRodionov ArtemijRodionov

Labels
3 we can defer this issue. But it'll good to implement it 30 mins middle-sized issue. Usually a part of feature or a fix cleanup everything that do project stronger, flexible, reusable front markup or work with js Metrics feature about business metrics
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@duker33 @ArtemijRodionov @0pdd