Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests_js_analytics.py:101-102: Create Goals class for... #929

Closed
0pdd opened this issue Jul 2, 2019 · 2 comments · Fixed by #933
Closed

tests_js_analytics.py:101-102: Create Goals class for... #929

0pdd opened this issue Jul 2, 2019 · 2 comments · Fixed by #933
Assignees
@ArtemijRodionov
Labels
1 burning issue 30 mins middle-sized issue. Usually a part of feature or a fix cleanup everything that do project stronger, flexible, reusable

Comments

@0pdd
Copy link
Collaborator

0pdd commented Jul 2, 2019

The puzzle 808-f72e84e8 from #808 has to be resolved:

shopelectro/shopelectro/tests/tests_js_analytics.py

Lines 101 to 102 in de1fc9c

# @todo #808:30m Create Goals class for tests.
# Remove these utility functions in favor of the class.

The puzzle was created by Artemiy on 02-Jul-19.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
@0pdd
Copy link
Collaborator Author

0pdd commented Jul 2, 2019

@artemiyds2 @duker33 please pay attention to this new issue.

0pdd referenced this issue Jul 2, 2019
@ArtemijRodionov
#808 review fixes (#923)
de1fc9c 
* Apply review fixes

* Create todo to create Goals class

* Skip test_accordion_minimized
This was referenced Jul 2, 2019
Closed
Closed
Closed
@ArtemijRodionov ArtemijRodionov added 1 burning issue 30 mins middle-sized issue. Usually a part of feature or a fix cleanup everything that do project stronger, flexible, reusable labels Jul 2, 2019
@0pdd 0pdd mentioned this issue Jul 2, 2019
Closed
@ArtemijRodionov ArtemijRodionov self-assigned this Jul 2, 2019
This was referenced Jul 2, 2019
Closed
Closed
@ArtemijRodionov ArtemijRodionov mentioned this issue Jul 4, 2019
Merged
ArtemijRodionov added a commit that referenced this issue Jul 5, 2019
@ArtemijRodionov
#929 ecommerce goals for tests (#933)
63a1de7 
* Create SiteDriver.delete_session method

* Create Goals interface for selenium tests

* Use the YandexEcommerceGoals in tests

* Review fixes

* Make rebase to master

* Apply linter rules
@0pdd 0pdd mentioned this issue Jul 5, 2019
Open
@0pdd
Copy link
Collaborator Author

0pdd commented Jul 5, 2019

@0pdd the puzzle #940 is still not solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ArtemijRodionov ArtemijRodionov

Labels
1 burning issue 30 mins middle-sized issue. Usually a part of feature or a fix cleanup everything that do project stronger, flexible, reusable
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#929 ecommerce goals for tests fidals/shopelectro
2 participants
@ArtemijRodionov @0pdd