-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#394 Redirects dep. stb2 #397
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@artemiy312 , it's bloked, but you can review it already |
duker33
force-pushed
the
rf140_redirects_dep
branch
from
July 3, 2018 13:28
d3e6706
to
bccd2b2
Compare
ArtemijRodionov
requested changes
Jul 3, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@artemiy312 , no, it just take some code from there. Because of deps. |
duker33
force-pushed
the
rf140_redirects_dep
branch
from
July 6, 2018 10:06
b7af262
to
c52e2c7
Compare
- Fix redirects mutlideps - Inherit redirects app from django's one - Fix commented code volumes in dc.yml - Change imports to new redirects app - Fix commented test and refarm-site dependency - Create test with unexpected behaviour explaining - Refresh py reqs according to stb
duker33
force-pushed
the
rf140_redirects_dep
branch
from
July 7, 2018 14:35
2b637ff
to
9e3b0d0
Compare
ArtemijRodionov
approved these changes
Jul 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #394
I'll create stb clone after this code approving