Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#394 Redirects dep. stb2 #397

Merged
merged 3 commits into from
Jul 9, 2018
Merged

#394 Redirects dep. stb2 #397

merged 3 commits into from
Jul 9, 2018

Conversation

duker33
Copy link
Contributor

@duker33 duker33 commented Jul 3, 2018

Closes #394

I'll create stb clone after this code approving

@duker33 duker33 added the blocked issue is blocked by another issue label Jul 3, 2018
@duker33 duker33 self-assigned this Jul 3, 2018
@duker33 duker33 requested a review from ArtemijRodionov July 3, 2018 13:24
@duker33 duker33 changed the title Rf140 redirects dep #394 Redirects dep Jul 3, 2018
@duker33
Copy link
Contributor Author

duker33 commented Jul 3, 2018

@artemiy312 , it's bloked, but you can review it already

@duker33 duker33 changed the title #394 Redirects dep #394 Redirects dep. stb2 Jul 3, 2018
@duker33 duker33 force-pushed the rf140_redirects_dep branch from d3e6706 to bccd2b2 Compare July 3, 2018 13:28
@duker33 duker33 added the review waits for review label Jul 3, 2018
Copy link
Contributor

@ArtemijRodionov ArtemijRodionov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@duker33
Seems, it is duplicate of #381

@duker33
Copy link
Contributor Author

duker33 commented Jul 3, 2018

Seems, it is duplicate of #381

@artemiy312 , no, it just take some code from there. Because of deps.
Let's wait for merge

@duker33 duker33 removed the review waits for review label Jul 3, 2018
@duker33 duker33 force-pushed the rf140_redirects_dep branch from b7af262 to c52e2c7 Compare July 6, 2018 10:06
duker33 added 2 commits July 7, 2018 17:34
- Fix redirects mutlideps
- Inherit redirects app from django's one
- Fix commented code volumes in dc.yml
- Change imports to new redirects app
- Fix commented test and refarm-site dependency
- Create test with unexpected behaviour explaining
- Refresh py reqs according to stb
@duker33 duker33 force-pushed the rf140_redirects_dep branch from 2b637ff to 9e3b0d0 Compare July 7, 2018 14:35
@duker33 duker33 requested a review from ArtemijRodionov July 7, 2018 14:35
@duker33 duker33 removed the blocked issue is blocked by another issue label Jul 9, 2018
@duker33 duker33 merged commit 5a8fa7f into master Jul 9, 2018
@duker33 duker33 deleted the rf140_redirects_dep branch July 9, 2018 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants