Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update remaining test targets to use undici #7761

Merged
merged 13 commits into from
Nov 10, 2023

Conversation

DellaBitta
Copy link
Contributor

Discussion

Some of our build/test targets from ddb-upgrade-node-fetch still require a migration from node-fetch to undici. These remaining changes aren't straightforward so I'm creating a sub branch to iron out the required changes.

Testing

Local / CI

API Changes

N/A

Copy link

changeset-bot bot commented Nov 9, 2023

⚠️ No Changeset found

Latest commit: 8795dfd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 9, 2023

Size Report 1

Affected Products

  • @firebase/rules-unit-testing

    TypeBase (3febc4c)Merge (c1bba13)Diff
    main17.8 kB17.8 kB-9 B (-0.1%)
  • @firebase/storage

    TypeBase (3febc4c)Merge (c1bba13)Diff
    browser57.8 kB57.8 kB-18 B (-0.0%)
    esm564.4 kB64.3 kB-18 B (-0.0%)
    main59.4 kB59.4 kB-16 B (-0.0%)
    module57.8 kB57.8 kB-18 B (-0.0%)
  • bundle

    TypeBase (3febc4c)Merge (c1bba13)Diff
    storage (uploadBytes)48.2 kB47.9 kB-253 B (-0.5%)
    storage (uploadBytesResumable)58.1 kB57.9 kB-253 B (-0.4%)
    storage (uploadString)48.4 kB48.1 kB-253 B (-0.5%)
  • firebase

    TypeBase (3febc4c)Merge (c1bba13)Diff
    firebase-compat.js778 kB778 kB-6 B (-0.0%)
    firebase-storage-compat.js41.3 kB40.3 kB-986 B (-2.4%)
    firebase-storage.js46.4 kB46.2 kB-246 B (-0.5%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/eRjQwVvGyh.html

@DellaBitta DellaBitta changed the title Update remainin testing targets to use undici Update remaining test targets to use undici Nov 9, 2023
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 9, 2023

Size Analysis Report 1

Affected Products

  • @firebase/storage

    • _FbsBlob

      Size

      TypeBase (3febc4c)Merge (c1bba13)Diff
      size15.4 kB15.4 kB-20 B (-0.1%)
      size-with-ext-deps33.6 kB32.5 kB-1.08 kB (-3.2%)

      External Dependency

      ModuleBase (3febc4c)Merge (c1bba13)Diff
      @firebase/util

      FirebaseError
      isNode

      FirebaseError

      - isNode

    • _UploadTask

      Size

      TypeBase (3febc4c)Merge (c1bba13)Diff
      size31.0 kB31.0 kB-20 B (-0.1%)
      size-with-ext-deps49.2 kB48.1 kB-1.08 kB (-2.2%)

      External Dependency

      ModuleBase (3febc4c)Merge (c1bba13)Diff
      @firebase/util

      FirebaseError
      isNode

      FirebaseError

      - isNode

    • uploadBytes

      Size

      TypeBase (3febc4c)Merge (c1bba13)Diff
      size21.2 kB21.2 kB-20 B (-0.1%)
      size-with-ext-deps39.4 kB38.4 kB-1.09 kB (-2.8%)

      External Dependency

      ModuleBase (3febc4c)Merge (c1bba13)Diff
      @firebase/util

      FirebaseError
      getModularInstance
      isNode

      FirebaseError
      getModularInstance

      - isNode

    • uploadBytesResumable

      Size

      TypeBase (3febc4c)Merge (c1bba13)Diff
      size31.1 kB31.1 kB-20 B (-0.1%)
      size-with-ext-deps49.4 kB48.3 kB-1.09 kB (-2.2%)

      External Dependency

      ModuleBase (3febc4c)Merge (c1bba13)Diff
      @firebase/util

      FirebaseError
      getModularInstance
      isNode

      FirebaseError
      getModularInstance

      - isNode

    • uploadString

      Size

      TypeBase (3febc4c)Merge (c1bba13)Diff
      size21.4 kB21.4 kB-20 B (-0.1%)
      size-with-ext-deps39.7 kB38.6 kB-1.09 kB (-2.7%)

      External Dependency

      ModuleBase (3febc4c)Merge (c1bba13)Diff
      @firebase/util

      FirebaseError
      getModularInstance
      isNode

      FirebaseError
      getModularInstance

      - isNode

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/imumX1XiEh.html

@DellaBitta DellaBitta marked this pull request as ready for review November 10, 2023 16:27
@DellaBitta DellaBitta merged commit b41fcde into ddb-upgrade-node-fetch Nov 10, 2023
38 checks passed
@DellaBitta DellaBitta deleted the ddb_undici_testing branch November 10, 2023 16:28
@firebase firebase locked and limited conversation to collaborators Dec 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants