Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update remaining test targets to use undici #7761

Merged
merged 13 commits into from
Nov 10, 2023
Merged

Update remaining test targets to use undici #7761

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
1c49225
added undici messaging integration test
DellaBitta Nov 9, 2023
b80eced
messaging itest source uses undici
DellaBitta Nov 9, 2023
acd536e
rules-unit-testing util uses undici
DellaBitta Nov 9, 2023
086aaab
spy undici fetch instead of fetch default
DellaBitta Nov 9, 2023
841f07e
rules and util undicfetchified
DellaBitta Nov 9, 2023
9f6cdfb
remove fetch-specific check in storage type.ts
DellaBitta Nov 9, 2023
bdcfe09
storage lint fix
DellaBitta Nov 9, 2023
87ed6c4
update emulator scripts to use undici
DellaBitta Nov 9, 2023
0c747a0
add write stream for response object
DellaBitta Nov 9, 2023
1e0cbdf
body member, not a method
DellaBitta Nov 9, 2023
1dcf6c0
create writableStream
DellaBitta Nov 10, 2023
b0f4c59
revert undici in emulator.ts
DellaBitta Nov 10, 2023
8795dfd
test_enviornment uses undici to clearFirestore
DellaBitta Nov 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove fetch-specific check in storage type.ts
  • Loading branch information
@DellaBitta
DellaBitta committed Nov 9, 2023
commit 9f6cdfb6b2ea0b307feab5da789a9bc84b27c206
4 changes: 1 addition & 3 deletions packages/storage/src/implementation/type.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,7 @@ export function isNativeBlob(p: unknown): p is Blob {
}

export function isNativeBlobDefined(): boolean {
// Note: The `isNode()` check can be removed when `node-fetch` adds native Blob support
// PR: https://github.com/node-fetch/node-fetch/pull/1664
return typeof Blob !== 'undefined' && !isNode();
return typeof Blob !== 'undefined';
}

export function validateNumber(
Expand Down