[Bug Fix] Net income adjustment for no revenue/expense lines

CHANGELOG.md

@@ -1,3 +1,10 @@
+# dbt_quickbooks v0.17.1
+[PR #149](https://github.com/fivetran/dbt_quickbooks/pull/149) introduces the following updates:
+
+## Bug Fix
+- Updated the logic in `int_quickbooks__retained_earnings` to ensure accounting periods with no revenue and expense class lines were accounted for. 
+  - This will ensure the net income adjustment is available regardless of existing revenue or expenses.
+
 # dbt_quickbooks v0.17.0
 [PR #146](https://github.com/fivetran/dbt_quickbooks/pull/146) introduces the following updates:
 

dbt_project.yml

@@ -1,7 +1,7 @@
 config-version: 2
 name: 'quickbooks'
 
-version: '0.17.0'
+version: '0.17.1'
 
 require-dbt-version: [">=1.3.0", "<2.0.0"]
 

integration_tests/dbt_project.yml

@@ -1,6 +1,6 @@
 name: 'quickbooks_integration_tests'
 
-version: '0.17.0'
+version: '0.17.1'
 
 profile: 'integration_tests'
 config-version: 2

models/intermediate/int_quickbooks__retained_earnings.sql

@@ -4,42 +4,19 @@ with general_ledger_balances as (
     from {{ ref('int_quickbooks__general_ledger_balances') }}
 ),
 
-revenue_starter as (
+net_income_loss as (
 
     select
         period_first_day,
         source_relation,
-        sum(period_net_change) as revenue_net_change,
-        sum(period_net_converted_change) as revenue_net_converted_change
+        sum(case when account_class = 'Revenue' then period_net_change else 0 end) as revenue_net_change,
+        sum(case when account_class = 'Revenue' then period_net_converted_change else 0 end) as revenue_net_converted_change,
+        sum(case when account_class = 'Expense' then period_net_change else 0 end) as expense_net_change,
+        sum(case when account_class = 'Expense' then period_net_converted_change else 0 end) as expense_net_converted_change
     from general_ledger_balances
-
-    where account_class = 'Revenue'
-
     {{ dbt_utils.group_by(2) }} 
 ),
 
-expense_starter as (
-
-    select 
-        period_first_day,
-        source_relation,
-        sum(period_net_change) as expense_net_change,
-        sum(period_net_converted_change) as expense_net_converted_change
-    from general_ledger_balances
-
-    where account_class = 'Expense'
-
-    {{ dbt_utils.group_by(2) }} 
-),
-
-net_income_loss as (
-
-    select *
-    from revenue_starter
-
-    join expense_starter 
-        using (period_first_day, source_relation)
-),
 retained_earnings_starter as (
 
     select