ROS driver rework #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 31, 2024 15:26
…ified the TF tree, and solved several bugs in the LLH message.
jwahlen64
reviewed
Jun 3, 2024
There was a problem hiding this comment.
At this point it might be worth considering introducing a more generic odometry converter class for OdometryConverter, OdomenuConverter and OdomshConverter to inherit from. Both to reduce duplicate code and for maintainability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworked the ROS driver to include ODOMSH and ODOMENU messages, simplified the TF tree, and solved several bugs in the LLH message.