Fix packaging dependency in cufinufft (#612)

* ci: try just importing cufinufft * cu+py: add packaging to dependencies * docs: update changelog
flatironinstitute · Jan 29, 2025 · 2f3e745 · 2f3e745
1 parent 92e975c
commit 2f3e745
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 1 deletion.
diff --git a/CHANGELOG b/CHANGELOG
@@ -40,6 +40,7 @@ Master, using release name V 2.4.0 (1/7/25)
 * Add options for user-provided FFTW locker (PR548, Blackwell). These options
   can be be used to prevent crashes when a user is creating/destroying FFTW
   plans and FINUFFT plans in threads simultaneously.
+* Fixed missing dependency on `packaging` in the Python `cufinufft` package.
 
 V 2.3.1 (11/25/24) minor update release (continued support on 2.3.X branch)
 

diff --git a/Jenkinsfile b/Jenkinsfile
@@ -55,6 +55,10 @@ pipeline {
         --config-settings=cmake.define.CMAKE_CUDA_ARCHITECTURES="${cuda_arch}" \
         python/cufinufft
     '''
+    sh '''#!/bin/bash -ex
+      source $HOME/bin/activate
+        python -c "import cufinufft"
+    '''
     sh '''#!/bin/bash -ex
       source $HOME/bin/activate
       python3 -m pip install --no-cache-dir --upgrade pycuda cupy-cuda112 numba

diff --git a/python/cufinufft/pyproject.toml b/python/cufinufft/pyproject.toml
@@ -11,7 +11,7 @@ name = "cufinufft"
 description = "Non-uniform fast Fourier transforms on the GPU"
 readme = "README.md"
 requires-python = ">=3.8"
-dependencies = ["numpy"]
+dependencies = ["numpy", "packaging"]
 authors = [
     {name = "Yu-shuan Melody Shih"},
     {name = "Garrett Wright"},