-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the upstream version of finufft #107
Conversation
I think we probably want to compile the static library with |
It looks like we need to set the In any case, this seems to have pushed the MacOS error to a missing FFTW dep. Maybe we need an explicit FFTW dependency in our CMake? Not sure why Ubuntu would work in that case, maybe because it's installing the headers in system paths? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Although we might want to wait until finufft 2.3 lands, which should be in the next week.
finufft 2.3 is out! I updated the vendored dependency here, and things look good. Ready to merge? |
Thanks!! |
No description provided.