-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add packaging documentation about Ubuntu 24.04 #8889
Open
markuman
wants to merge
24
commits into
fluent:master
Choose a base branch
from
markuman:docs-2404
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,062
−177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markuman
requested review from
niedbalski,
patrick-stephens and
celalettin1286
as code owners
May 29, 2024 07:06
2 tasks
patrick-stephens
approved these changes
May 29, 2024
Can you sort the DCO @markuman as it's a requirement to be merged? |
Signed-off-by: Mateusz Warzyński <[email protected]> Signed-off-by: Markus Bergholz <[email protected]>
Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action) from 2.3.1 to 2.3.3. - [Release notes](https://github.com/ossf/scorecard-action/releases) - [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md) - [Commits](ossf/scorecard-action@0864cf1...dc50aa9) --- updated-dependencies: - dependency-name: ossf/scorecard-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Markus Bergholz <[email protected]>
Signed-off-by: braydonk <[email protected]> Signed-off-by: Markus Bergholz <[email protected]>
This commit increases the max length of kafka dynamic topics. As the limit previously set (64) seemed arbitrary, and kafka allows for a maximum of 249 characters per topic, I think fluentbit should reflect that limit. Signed-off-by: Michael Meunier <[email protected]> Signed-off-by: Markus Bergholz <[email protected]>
Insert implies that adding new key-value pairs of labels. However, we did put the existence check for the keys of labels. This shouldn't be effective for such operation. Signed-off-by: Hiroshi Hatake <[email protected]> Signed-off-by: Markus Bergholz <[email protected]>
…minor (fluent#8797) Signed-off-by: xiaobaowen <[email protected]> Co-authored-by: xiaobaowen <[email protected]> Signed-off-by: Markus Bergholz <[email protected]>
Signed-off-by: Maneesh Singh <[email protected]> Signed-off-by: Markus Bergholz <[email protected]>
…8751 These options are useful when there is no attribute in the incoming log that indicates the field to use for the `source` or `service` attributes, but otherwise the backend will automatically look for both in the incoming log attributes. Ref: fluent#8687 Signed-off-by: Jesse Szwedko <[email protected]> Signed-off-by: Markus Bergholz <[email protected]>
* api/v1/traces: validate inputs when enabling traces. validate the array of inputs when enabling multiple traces that they are strings. this patch also refactors out the allocation of said input name. Signed-off-by: Phillip Adair Stewart Whelan <[email protected]> * api/v1/traces: disable traces api when tracing is disabled. Signed-off-by: Phillip Adair Stewart Whelan <[email protected]> * api/v1/trace: use macros for strings and lengths in responses. avoid strlen when creating http response, especially in loops, by predefining them via macros. Signed-off-by: Phillip Whelan <[email protected]> * api/v1/trace: use sizeof for string length macros. Signed-off-by: Phillip Whelan <[email protected]> * api/v1/trace: use signed lenghts for strings. this avoid potential integer overflows when using them as specifiers for format strings. Signed-off-by: Phillip Whelan <[email protected]> * api/v1/traces: use macro for inputs string. Signed-off-by: Phillip Whelan <[email protected]> * api/v1/traces: use sizeof when comparing against base path. Signed-off-by: Phillip Whelan <[email protected]> * api/v1/traces: replace strlen with flb_sds_len when using flb_sds_t. Signed-off-by: Phillip Whelan <[email protected]> --------- Signed-off-by: Phillip Adair Stewart Whelan <[email protected]> Signed-off-by: Phillip Whelan <[email protected]> Signed-off-by: Markus Bergholz <[email protected]>
…us remote write protocol (fluent#8725) in_prometheus_remote_write: Implement prometheus remote write input plugin. This plugin is able to handle the following types currently: - Counter - Gauge - Untyped - Histogram Summary type of metrics shouldn't be handled and decoded correctly for now. --------- Signed-off-by: Hiroshi Hatake <[email protected]> Signed-off-by: Markus Bergholz <[email protected]>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: edsiper <[email protected]> Signed-off-by: Markus Bergholz <[email protected]>
Signed-off-by: Patrick Stephens <[email protected]> Signed-off-by: Markus Bergholz <[email protected]>
Signed-off-by: Hiroyuki Hasebe <[email protected]> Signed-off-by: Markus Bergholz <[email protected]>
The following patch perform 2 changes in the code that helps to fix the problems found with Splunk hec token handling: 1. In the recent PR fluent#8793, when using the record accessor API flb_ra_translate_check() to validate if the hec_token field exists, leads to noisy log messages since that function warns the issue if the field is not found. Most of users are not using hec_token set by Splunk input plugin, so their logging gets noisy. This patch replaces that call with flb_ra_translate() which fixes the problem. 2. If hec_token was set in the record metadata, it was being store in the main context of the plugin, however the flush callbacks that formats and deliver the data runs in separate/parallel threads that could lead to a race condition if more than onen thread tries to manipulate the value. This patch adds protection to the context value so it becomes thread safe. Signed-off-by: Eduardo Silva <[email protected]> Signed-off-by: Markus Bergholz <[email protected]>
The `total_size_threshold` field was originally an unsigned int. The field in the config map uses `FLB_CONFIG_MAP_SIZE`, which reads the value as a `size_t` and then writes it to the offset of the field in the struct. On a 64-bit machine, this is 8 bytes. This means the 8 byte value would be written at this offset, as a result overriding the value of the next struct field. This would cause `string_inserts` with default values to end up being `false` when it should be `true`. This PR changes `total_size_threshold` to a `size_t`. This seems consistent with other usages of `FLB_CONFIG_MAP_SIZE` that I was able to find. Signed-off-by: braydonk <[email protected]> Signed-off-by: Markus Bergholz <[email protected]>
This patch passes an cmt_out_context pointer so that output processors can modify metrics. Signed-off-by: Thiago Padilha <[email protected]> Signed-off-by: Markus Bergholz <[email protected]>
…ut processor Signed-off-by: Thiago Padilha <[email protected]> Signed-off-by: Markus Bergholz <[email protected]>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: edsiper <[email protected]> Signed-off-by: Markus Bergholz <[email protected]>
Signed-off-by: Markus Bergholz <[email protected]>
…gEntry. (fluent#8850) Write payload to textPayload field of LogEntry if the text_payload_key is string format and the only field after stripping special fields. Signed-off-by: shuaichen <[email protected]> Signed-off-by: Markus Bergholz <[email protected]>
…token behavior (fix fluent#8867) In the previous Splunk metadata fix, I introduced an issue where the metadata auth header was always set even if the metadata was not there, the code was generating an emptry string which leads to skip the classic splunk_token auth mechanism. This patch corrects the recent bug by validating first and returning a proper NULL when metadata auth header (hec_token) is not there. Signed-off-by: Eduardo Silva <[email protected]> Signed-off-by: Markus Bergholz <[email protected]>
The tls variable for out_flush_params is not initialized as the flb_start function is not called during the dry run. Call flb_init directly and then shutdown the engine. configuration test is successful ================================================================= ==63633==ERROR: AddressSanitizer: attempting free on address which was not malloc()-ed: 0x0001f71b3ac0 in thread T0 #0 0x103c9f260 in wrap_free+0x98 (libclang_rt.asan_osx_dynamic.dylib:arm64e+0x53260) fluent#1 0x100179d9c in flb_free flb_mem.h:127 fluent#2 0x10017f4a0 in flb_output_exit flb_output.c:481 fluent#3 0x1001cb038 in flb_engine_shutdown flb_engine.c:1119 fluent#4 0x10010d45c in flb_destroy flb_lib.c:240 fluent#5 0x100008c40 in flb_main fluent-bit.c:1348 fluent#6 0x10000c644 in main fluent-bit.c:1456 fluent#7 0x18f11e0dc (<unknown module>) frame fluent#6: 0x000000010017f4a4 fluent-bit`flb_output_exit(config=0x0000000102b00200) at flb_output.c:481:9 478 479 params = FLB_TLS_GET(out_flush_params); 480 if (params) { -> 481 flb_free(params); 482 } 483 } Signed-off-by: Holger Hans Peter Freyther <[email protected]> Signed-off-by: Markus Bergholz <[email protected]>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: Markus Bergholz <[email protected]>
Signed-off-by: Markus Bergholz <[email protected]>
markuman
requested review from
braydonk,
igorpeshansky,
qingling128,
nokute78,
edsiper,
PettitWesley,
fujimotos,
leonardo-albertovich and
koleini
as code owners
May 29, 2024 08:36
done |
I think something has gone wrong with rebase to pick up all those changes. |
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enter
[N/A]
in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-test
label to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.