Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add packaging documentation about Ubuntu 24.04 #8889

Open
wants to merge 24 commits into
base: master
Choose a base branch
from

Conversation

markuman
Copy link
Contributor


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • [ N/A] Example configuration file for the change
  • [N/A ] Debug log output from testing the change
  • [N/A ] Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • [ N/A] Run local packaging test showing all targets (including any new ones) build.
  • [ N/A] Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • [ N/A] Documentation required for this feature

Backporting

  • [ N/A] Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

@patrick-stephens
Copy link
Contributor

Can you sort the DCO @markuman as it's a requirement to be merged?

mwarzynski and others added 23 commits May 29, 2024 10:36
Signed-off-by: Mateusz Warzyński <[email protected]>
Signed-off-by: Markus Bergholz <[email protected]>
Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action) from 2.3.1 to 2.3.3.
- [Release notes](https://github.com/ossf/scorecard-action/releases)
- [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md)
- [Commits](ossf/scorecard-action@0864cf1...dc50aa9)

---
updated-dependencies:
- dependency-name: ossf/scorecard-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Markus Bergholz <[email protected]>
Signed-off-by: braydonk <[email protected]>
Signed-off-by: Markus Bergholz <[email protected]>
This commit increases the max length of kafka dynamic topics.

As the limit previously set (64) seemed arbitrary, and kafka allows for
a maximum of 249 characters per topic, I think fluentbit should reflect
that limit.

Signed-off-by: Michael Meunier <[email protected]>
Signed-off-by: Markus Bergholz <[email protected]>
Insert implies that adding new key-value pairs of labels.
However, we did put the existence check for the keys of labels.
This shouldn't be effective for such operation.

Signed-off-by: Hiroshi Hatake <[email protected]>
Signed-off-by: Markus Bergholz <[email protected]>
…minor (fluent#8797)

Signed-off-by: xiaobaowen <[email protected]>
Co-authored-by: xiaobaowen <[email protected]>
Signed-off-by: Markus Bergholz <[email protected]>
Signed-off-by: Maneesh Singh <[email protected]>
Signed-off-by: Markus Bergholz <[email protected]>
…8751

These options are useful when there is no attribute in the incoming log
that indicates the field to use for the `source` or `service`
attributes, but otherwise the backend will automatically look for both
in the incoming log attributes.

Ref: fluent#8687

Signed-off-by: Jesse Szwedko <[email protected]>
Signed-off-by: Markus Bergholz <[email protected]>
* api/v1/traces: validate inputs when enabling traces.

validate the array of inputs when enabling multiple traces that
they are strings.

this patch also refactors out the allocation of said input name.

Signed-off-by: Phillip Adair Stewart Whelan <[email protected]>

* api/v1/traces: disable traces api when tracing is disabled.

Signed-off-by: Phillip Adair Stewart Whelan <[email protected]>

* api/v1/trace: use macros for strings and lengths in responses.

avoid strlen when creating http response, especially in loops,
by predefining them via macros.

Signed-off-by: Phillip Whelan <[email protected]>

* api/v1/trace: use sizeof for string length macros.

Signed-off-by: Phillip Whelan <[email protected]>

* api/v1/trace: use signed lenghts for strings.

this avoid potential integer overflows when using them as
specifiers for format strings.

Signed-off-by: Phillip Whelan <[email protected]>

* api/v1/traces: use macro for inputs string.

Signed-off-by: Phillip Whelan <[email protected]>

* api/v1/traces: use sizeof when comparing against base path.

Signed-off-by: Phillip Whelan <[email protected]>

* api/v1/traces: replace strlen with flb_sds_len when using flb_sds_t.

Signed-off-by: Phillip Whelan <[email protected]>

---------

Signed-off-by: Phillip Adair Stewart Whelan <[email protected]>
Signed-off-by: Phillip Whelan <[email protected]>
Signed-off-by: Markus Bergholz <[email protected]>
…us remote write protocol (fluent#8725)

 in_prometheus_remote_write: Implement prometheus remote write input plugin. This plugin is able to handle the following types currently:

- Counter
- Gauge
- Untyped
- Histogram

Summary type of metrics shouldn't be handled and decoded correctly for now.

---------

Signed-off-by: Hiroshi Hatake <[email protected]>
Signed-off-by: Markus Bergholz <[email protected]>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: edsiper <[email protected]>
Signed-off-by: Markus Bergholz <[email protected]>
Signed-off-by: Hiroyuki Hasebe <[email protected]>

Signed-off-by: Markus Bergholz <[email protected]>
The following patch perform 2 changes in the code that helps to fix the
problems found with Splunk hec token handling:

1. In the recent PR fluent#8793, when using the record accessor API flb_ra_translate_check()
   to validate if the hec_token field exists, leads to noisy log messages since
   that function warns the issue if the field is not found. Most of users are not
   using hec_token set by Splunk input plugin, so their logging gets noisy.

   This patch replaces that call with flb_ra_translate() which fixes the problem.

2. If hec_token was set in the record metadata, it was being store in the main
   context of the plugin, however the flush callbacks that formats and deliver the
   data runs in separate/parallel threads that could lead to a race condition if
   more than onen thread tries to manipulate the value.

   This patch adds protection to the context value so it becomes thread safe.

Signed-off-by: Eduardo Silva <[email protected]>
Signed-off-by: Markus Bergholz <[email protected]>
The `total_size_threshold` field was originally an unsigned int. The
field in the config map uses `FLB_CONFIG_MAP_SIZE`, which reads the
value as a `size_t` and then writes it to the offset of the field in the
struct. On a 64-bit machine, this is 8 bytes. This means the 8 byte
value would be written at this offset, as a result overriding the value
of the next struct field. This would cause `string_inserts` with default
values to end up being `false` when it should be `true`.

This PR changes `total_size_threshold` to a `size_t`. This seems
consistent with other usages of `FLB_CONFIG_MAP_SIZE` that I was able to
find.

Signed-off-by: braydonk <[email protected]>
Signed-off-by: Markus Bergholz <[email protected]>
This patch passes an cmt_out_context pointer so that output processors
can modify metrics.

Signed-off-by: Thiago Padilha <[email protected]>
Signed-off-by: Markus Bergholz <[email protected]>
…ut processor

Signed-off-by: Thiago Padilha <[email protected]>
Signed-off-by: Markus Bergholz <[email protected]>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: edsiper <[email protected]>
Signed-off-by: Markus Bergholz <[email protected]>
…gEntry. (fluent#8850)

Write payload to textPayload field of LogEntry if the text_payload_key
is string format and the only field after stripping special fields.

Signed-off-by: shuaichen <[email protected]>
Signed-off-by: Markus Bergholz <[email protected]>
…token behavior (fix fluent#8867)

In the previous Splunk metadata fix, I introduced an issue where the metadata auth header was
always set even if the metadata was not there, the code was generating an emptry string which
leads to skip the classic splunk_token auth mechanism.

This patch corrects the recent bug by validating first and returning a proper NULL when
metadata auth header (hec_token) is not there.

Signed-off-by: Eduardo Silva <[email protected]>
Signed-off-by: Markus Bergholz <[email protected]>
The tls variable for out_flush_params is not initialized as the
flb_start function is not called during the dry run. Call flb_init
directly and then shutdown the engine.

configuration test is successful
=================================================================
==63633==ERROR: AddressSanitizer: attempting free on address which was not malloc()-ed: 0x0001f71b3ac0 in thread T0
    #0 0x103c9f260 in wrap_free+0x98 (libclang_rt.asan_osx_dynamic.dylib:arm64e+0x53260)
    fluent#1 0x100179d9c in flb_free flb_mem.h:127
    fluent#2 0x10017f4a0 in flb_output_exit flb_output.c:481
    fluent#3 0x1001cb038 in flb_engine_shutdown flb_engine.c:1119
    fluent#4 0x10010d45c in flb_destroy flb_lib.c:240
    fluent#5 0x100008c40 in flb_main fluent-bit.c:1348
    fluent#6 0x10000c644 in main fluent-bit.c:1456
    fluent#7 0x18f11e0dc  (<unknown module>)

frame fluent#6: 0x000000010017f4a4 fluent-bit`flb_output_exit(config=0x0000000102b00200) at flb_output.c:481:9
   478
   479 	    params = FLB_TLS_GET(out_flush_params);
   480 	    if (params) {
-> 481 	        flb_free(params);
   482 	    }
   483 	}

Signed-off-by: Holger Hans Peter Freyther <[email protected]>
Signed-off-by: Markus Bergholz <[email protected]>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: Markus Bergholz <[email protected]>
@markuman
Copy link
Contributor Author

Can you sort the DCO @markuman as it's a requirement to be merged?

done

@patrick-stephens
Copy link
Contributor

I think something has gone wrong with rebase to pick up all those changes.

Copy link
Contributor

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.