Skip to content

Allow refining Self #192

Allow refining Self

Allow refining Self #192

Triggered via pull request January 3, 2024 00:59
Status Failure
Total duration 1m 9s
Artifacts

ci.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

4 errors and 4 warnings
lint
Process completed with exit code 1.
failed to resolve: use of undeclared crate or module `kw`: crates/flux-desugar/src/sort_resolver.rs#L123
error[E0433]: failed to resolve: use of undeclared crate or module `kw` --> crates/flux-desugar/src/sort_resolver.rs:123:30 | 123 | && ident.name == kw::SelfUpper | ^^ use of undeclared crate or module `kw` | help: consider importing this module | 1 + use rustc_span::symbol::kw; |
clippy
Clippy had exited with the 101 exit code
tests
Process completed with exit code 101.
unused import: `symbol::kw::SelfUpper`: crates/flux-desugar/src/sort_resolver.rs#L14
warning: unused import: `symbol::kw::SelfUpper` --> crates/flux-desugar/src/sort_resolver.rs:14:5 | 14 | symbol::kw::SelfUpper, | ^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default
this expression creates a reference which is immediately dereferenced by the compiler: crates/flux-fhir-analysis/src/conv.rs#L161
warning: this expression creates a reference which is immediately dereferenced by the compiler --> crates/flux-fhir-analysis/src/conv.rs:161:49 | 161 | .map(|kind| conv_generic_param_kind(&kind)) | ^^^^^ help: change this to: `kind` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default
methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference: crates/flux-middle/src/rustc/lowering.rs#L55
warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference --> crates/flux-middle/src/rustc/lowering.rs:55:26 | 55 | pub(crate) fn to_err(self) -> UnsupportedErr { | ^^^^ | = help: consider choosing a less ambiguous name = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention = note: `#[warn(clippy::wrong_self_convention)]` on by default
clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/[email protected]. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/