oci: Use controller-runtime pkg/log specifically

[darkowlzz]

This helps avoid importing the controller-runtime pkg/client/config package which has a flag initialization for "kubeconfig". This results in all the users of the oci package to also have the flag initialized in their applications. The root level controller-runtime package has type aliases which we use a lot for ease of use, but the package also imports the client config package.
The usage of controller-runtime in oci package is just for logging. Importing the pkg/log package specifically helps avoid importing the client config which sets the flag.

Fixes #645

Verified by building kyverno locally and testing.

GCP integration test run: https://github.com/fluxcd/pkg/actions/runs/6098520241/job/16548522220

[makkes]

Perfect, thanks. I was able to verify that it works as expected when imported.

[makkes]

@darkowlzz we should add a test case that prevents a regression here.

[darkowlzz]

we should add a test case that prevents a regression here.

@makkes we can add a test that imports this package and checks for flags. But this is a very general problem for all the packages that use controller-runtime. Such a test will have to be added to all the other packages too to make sure they never import the root level controller-runtime package accidentally. I'm not sure how feasible that is. Once the upstream removes the flag initialization, all these work would become unnecessary.
But this seems to be a good problem to solve for an independent tool that go packages can import in their tests and run to make sure that they don't inject any unintended flags.

[makkes]

But this is a very general problem for all the packages that use controller-runtime

We can start small by adding a test for this one. No need to make this just another huge project.

[darkowlzz]

I've added a small test under oci/auth as a black box test to import the login package which imports all the other packages. Being in test, the flag contains all the test flags. The test checks for existence of any non-test flag.

[realshuting]

Is there an ETA when this fix will be merged? We (Kyverno) encountered this issue while importing some of the fluxcd packages, would love to get this in!

[stefanprodan]

@realshuting you can now use github.com/fluxcd/pkg/oci v0.31.1

[realshuting]

Thank you @stefanprodan!

[makkes]

Verified the test fails without the fix. Thanks @darkowlzz