Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oci: Use controller-runtime pkg/log specifically #646

Merged
merged 2 commits into from
Sep 7, 2023
Merged

oci: Use controller-runtime pkg/log specifically #646

merged 2 commits into from
Sep 7, 2023

Commits on Sep 6, 2023

  1. oci: Use controller-runtime pkg/log explicitly 

    This helps avoid importing the controller-runtime pkg/client/config
package which has a flag initialization for "kubeconfig". This results
in all the users of the oci package to also have the flag initialized in
their applications.
The usage of controller-runtime in oci package is just for logging.
Importing the pkg/log package specifically helps avoid importing the
client config which sets the flag.

Signed-off-by: Sunny <[email protected]>
    @darkowlzz
    darkowlzz committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    f01d884 View commit details
    Browse the repository at this point in the history

  2. oci/auth: Add test to check for non-test flags 

    Add a black box test to import the auth package as a consumer of the
package and make sure that no flags are injected. Being in a test, it
ignores all the default test flags with "test." prefix.

Signed-off-by: Sunny <[email protected]>
    @darkowlzz
    darkowlzz committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    e6669d8 View commit details
    Browse the repository at this point in the history