fix(quotes): Add double-quotes for REDIS_PASSWORD
#18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shymega
added a commit
to shymega/fly-apps-redis
that referenced
this pull request
Jan 2, 2024
This is related to fly-apps#18, in the context of resolving double-quote escape issues. There's no known report of this Dockerfile being an issue in the wild, but given fly-apps#18, I felt it would be a good idea to nip it in the bud.
This allows special characters to be used, fixing: fly-apps#3 It will also ensure that the resulting server instance remains accessible when the password has special characters. Had to double-quote the `redis-server` password argument, and escape the double quotes in `PW_ARG`, to make sure it was assigned correctly. Signed-off-by: Dom Rodriguez <[email protected]>
This should prevent issues with whitespace, or globbing-related issues. Signed-off-by: Dom Rodriguez <[email protected]>
shymega
added a commit
to shymega/fly-apps-redis
that referenced
this pull request
Jan 4, 2024
This is related to fly-apps#18, in the context of resolving double-quote escape issues. There's no known report of this Dockerfile being an issue in the wild, but given fly-apps#18, I felt it would be a good idea to nip it in the bud. Signed-off-by: Dom Rodriguez <[email protected]>
shymega
force-pushed
the
enhancement/doublequotes/script
branch
from
5a1ef36
to
6eab9ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows special characters to be used, fixing: #3
It will also ensure that the resulting server instance remains accessible when the password has special characters.