Return ResourceWrapper without pointer #4115
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Worker in async cache panics because it fails to cast resource to
*ResourceWrapper
cache (*Resource) -> cast to (*Resource) // it works
s3 (Resource) -> cast to (*Resource) // Failed to do type casting since we unmarshall the resource to
Resource
here.We read the resource from s3 bucket after restarting the propeller (cache becomes empty).
Type
Are all requirements met?
Complete description
^^^
Tracking Issue
NA
Follow-up issue
NA