Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add visibility control to dynamic log links #6000

Merged
merged 3 commits into from
Nov 15, 2024
Merged

Conversation

pingsutw
Copy link
Member

@pingsutw pingsutw commented Nov 12, 2024

Tracking issue

NA

Why are the changes needed?

HideOnceFinished config doesn't work with dynamic log links

What changes were proposed in this pull request?

Add ShowWhilePending and HideOnceFinished to the dynamic log links when creating the list of TaskLogs

How was this patch tested?

flytepropeller config

plugins:
  logs:
    kubernetes-enabled: true
    kubernetes-template-uri: http://localhost:30080/kubernetes-dashboard/#/log/{{.namespace }}/{{ .podName }
}/pod?namespace={{ .namespace }}
    cloudwatch-enabled: false
    stackdriver-enabled: false
    templates:
    - displayName: ShowPending
      # showWhilePending: true
      hideOnceFinished: true
      templateUris: 456
    dynamic-log-links:
    - vscode:
        displayName: VSCode
        hideOnceFinished: true
        templateUris: 123

Setup process

Screenshots

Screenshot 2024-11-14 at 4 55 45 PM Screenshot 2024-11-14 at 4 55 57 PM

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

#4726

Docs link

NA

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.03%. Comparing base (f20b8aa) to head (99c8988).
Report is 13 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6000      +/-   ##
==========================================
+ Coverage   36.95%   37.03%   +0.07%     
==========================================
  Files        1310     1313       +3     
  Lines      131464   131622     +158     
==========================================
+ Hits        48587    48749     +162     
+ Misses      78656    78645      -11     
- Partials     4221     4228       +7     
Flag Coverage Δ
unittests-datacatalog 51.58% <ø> (ø)
unittests-flyteadmin 54.10% <ø> (+0.02%) ⬆️
unittests-flytecopilot 22.23% <ø> (ø)
unittests-flytectl 62.46% <ø> (+0.06%) ⬆️
unittests-flyteidl 7.25% <ø> (+0.29%) ⬆️
unittests-flyteplugins 53.68% <100.00%> (-0.15%) ⬇️
unittests-flytepropeller 43.11% <ø> (+<0.01%) ⬆️
unittests-flytestdlib 55.18% <ø> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Kevin Su <[email protected]>
Copy link
Member

@Future-Outlier Future-Outlier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, can you priovide your config seciton for others to produce this easier in the future?

@Future-Outlier Future-Outlier merged commit d1a723e into master Nov 15, 2024
52 checks passed
@Future-Outlier Future-Outlier deleted the hide-link branch November 15, 2024 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants