CIRC-2198 Implement the code for the feature UXPROD-5001 #1521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…logic to store flag into database
AntonAntonich
changed the title
src/main/java/org/folio/circulation/resources/RequestNoticeSender.java
Outdated
Show resolved
Hide resolved
gurleenkaurbp
approved these changes
Dec 16, 2024
OleksandrVidinieiev
approved these changes
Dec 16, 2024
| @@ -427,6 +428,10 @@ public boolean hasLoan() { | |||
| return loan != null; | |||
| } | |||
|
|
|||
| public boolean getDcbReRequestCancellationValue() { | |||
There was a problem hiding this comment.
Suggested change
| public boolean getDcbReRequestCancellationValue() { | |
| public boolean isDcbReRequestCancellation() { |
| sendCancellationNoticeForRequestWithItemId(request); | ||
| } else { | ||
| sendCancellationNoticeForRequestWithoutItemId(request); | ||
| // Send the cancellation notice only if the isDcbReRequestCancellation flag is false |
There was a problem hiding this comment.
Do we really need this comment? I think code below speaks for itself
There was a problem hiding this comment.
will remove it
Comment on lines
33
to
34
| Mockito.verify(immediatePatronNoticeService, times(0)).acceptNoticeEvent(any()); | ||
| Mockito.verify(immediatePatronNoticeService, times(0)).sendNotice(any(), any()); |
There was a problem hiding this comment.
Suggested change
| Mockito.verify(immediatePatronNoticeService, times(0)).acceptNoticeEvent(any()); | |
| Mockito.verify(immediatePatronNoticeService, times(0)).sendNotice(any(), any()); | |
| Mockito.verify(immediatePatronNoticeService, times(0)).acceptNoticeEvent(any()); | |
| Mockito.verify(immediatePatronNoticeService, times(0)).sendNotice(any(), any()); |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Implement the code for the feature UXPROD-5001
Jira
CIRC-2198