-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CIRC-2198 Implement the code for the feature UXPROD-5001 #1521
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
1183999
UXPROD-5001 Avoid sending cancellation notice if the suppressNotifica…
Vignesh-kalyanasundaram 5121cf0
UXPROD-5001 Avoid sending cancellation notice if the suppressNotifica…
Vignesh-kalyanasundaram faca298
UXPROD-5001 renamed property to isDcbReRequestCancellation. Improved …
AntonAntonich 5e6f612
Merge branch 'refs/heads/master' into UXPROD-5001
AntonAntonich 7ab9055
UXPROD-5001 upd property description
AntonAntonich 48c3cbe
UXPROD-5001 Updated comment
AntonAntonich 8257312
UXPROD-5001 Add unit test
AntonAntonich 2ce03bc
UXPROD-5001 test refactoring
AntonAntonich b6c736e
UXPROD-5001 sonar
AntonAntonich 93478ab
Merge branch 'refs/heads/master' into UXPROD-5001
AntonAntonich 5d4a533
UXPROD-5001 sonar
AntonAntonich 7cc7e46
UXPROD-5001 sonar
AntonAntonich 0d74155
UXPROD-5001 refactored
AntonAntonich File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36 changes: 36 additions & 0 deletions
36
src/test/java/org/folio/circulation/resources/RequestNoticeSenderTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
package org.folio.circulation.resources; | ||
|
||
import static org.mockito.ArgumentMatchers.any; | ||
import static org.mockito.Mockito.times; | ||
|
||
import org.folio.circulation.domain.Request; | ||
import org.folio.circulation.domain.RequestAndRelatedRecords; | ||
import org.folio.circulation.domain.notice.ImmediatePatronNoticeService; | ||
import org.junit.jupiter.api.Test; | ||
import org.junit.jupiter.api.extension.ExtendWith; | ||
import org.mockito.InjectMocks; | ||
import org.mockito.Mock; | ||
import org.mockito.Mockito; | ||
import org.mockito.junit.jupiter.MockitoExtension; | ||
|
||
import api.support.builders.RequestBuilder; | ||
import io.vertx.core.json.JsonObject; | ||
|
||
@ExtendWith(MockitoExtension.class) | ||
class RequestNoticeSenderTest { | ||
|
||
@Mock | ||
private ImmediatePatronNoticeService immediatePatronNoticeService; | ||
@InjectMocks | ||
private RequestNoticeSender requestNoticeSender; | ||
|
||
@Test | ||
void shouldNotSendNotificationWhenIsDcbCancellationTrue() { | ||
JsonObject representation = new RequestBuilder().create(); | ||
representation.put("isDcbReRequestCancellation", true); | ||
requestNoticeSender.sendNoticeOnRequestCancelled( | ||
new RequestAndRelatedRecords(Request.from(representation))); | ||
Mockito.verify(immediatePatronNoticeService, times(0)).acceptNoticeEvent(any()); | ||
Mockito.verify(immediatePatronNoticeService, times(0)).sendNotice(any(), any()); | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.