[MODDATAIMP-931] DITF forward merge

[ncovercash]

Jira MODDATAIMP-931

To be merged with folio-org/mod-source-record-manager#809

TODOS and Open Questions

• RMB removed the language trait in v33.2 back in 2021 (via FOLIO-3351: Remove lang query parameter and language.raml trait raml#141). My working suspicion as to why this had not affected mod-DI yet is that data-import-raml-storage's version of raml-util was behind, and that mod-DI's version of data-import-raml-storage was even further behind than that, causing significant lag.
  • To use the newest version of data-import-raml-storage, which includes our added schemas, we must update our version.
  • The current fix is just to remove the lang param (never used) and add the new totalRecords field which, per the docs, should be sufficient.
  • We should probably open a ticket to ensure totalRecords eventually gets implemented as expected
    • Opened MODDATAIMP-938
• I'd like to update the tests of DataImportQueueItemDaoImpl to use a real DB instead of extensive mocking. This would help catch errors in schemas, get a bit more coverage, and be easier to maintain.
  • This was not done previously as, when we wrote the DAO tests, we were unable to get liquibase running in the test environment. This has been resolved.
• We can probably delete ModTenantApiTest — it's queries to /_/tenant and responses are tested as part of all other integration tests in AbstractRestTest
• Investigate and potentially implement the new refresh token API for system user login (deprecation plan)
• Use Java 17 patterns wherever applicable
  • .toList() on collectors
  • arrow switches
• Bump version number(s)?
• Bump interface version(s)?
• Bump other Maven dependencies?
• Cleanup .map(v -> someConcreteValue) calls to eliminate extra invocation overhead

Notes

I do not believe the code smell Replace this "switch" statement by "if" statements to increase readability needs to be addressed:

The switch statement here provides an easily readable and testable method to only cancel jobs which do not match those four statuses. An equivalent if would require a long and redundant boolean expression.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

99.7% Coverage
0.0% Duplication