Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MODSOURMAN-1049] DITF forward merge #809

Merged
merged 7 commits into from
Oct 9, 2023
Merged

[MODSOURMAN-1049] DITF forward merge #809

merged 7 commits into from
Oct 9, 2023

Conversation

ncovercash
Copy link
Member

@ncovercash ncovercash commented Oct 2, 2023 •
edited
Loading

Jira MODSOURMAN-1049

To be merged with folio-org/mod-data-import#298

Purpose

Merge changes from the DITF to support DI file slicing. This required changing logic in SRM to add a new job types COMPOSITE_PARENT and COMPOSITE_CHILD, as well as some additional job execution fields to support these associations.

Approach

By adding new DB fields to support these values as well as logic to support associations between the parent and children chunks (e.g. finishing the last child => the parent is finished).

Checklist

  • I have updated NEWS.md.
  • I have added javadocs to new methods.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation e.g. README.md.
  • I have ran karate tests against this feature.
  • Check coverage
  • Bump version number(s)?
  • Bump interface version(s)?
  • Create ticket to handle RMB upgrade totalRecords not done by DITF; the parameter was already added before our changes.

@ncovercash ncovercash changed the title [MODSOURMAN-1049] [DO NOT MERGE] DITF forward merge [MODSOURMAN-1049] DITF forward merge Oct 3, 2023
@ncovercash ncovercash mentioned this pull request Oct 4, 2023
Merged
16 tasks
@ncovercash ncovercash marked this pull request as ready for review October 9, 2023 14:02
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

87.3% 87.3% Coverage
0.0% 0.0% Duplication

@ncovercash ncovercash merged commit e51ec72 into master Oct 9, 2023
3 checks passed
@ncovercash ncovercash deleted the ditf-poppy branch October 9, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KaterynaSenchenko KaterynaSenchenko KaterynaSenchenko approved these changes

@TarasSpashchenko TarasSpashchenko TarasSpashchenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ncovercash @TarasSpashchenko @KaterynaSenchenko