MODSOURAMN-1063 - Update RecordProcessingLogDto to contain incoming record id #838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
save IncomingRecords with JournalRecords after incoming records are parsed
…d service layers functionality (#823)
…CE_CREATED event received (#834) MODSOURMAN-1070: Filled in two journals records for Instance and Marc bib during INSTANCE_CREATED event type
…d service layers functionality (#823)
…CE_CREATED event received (#834) MODSOURMAN-1070: Filled in two journals records for Instance and Marc bib during INSTANCE_CREATED event type
…-record-manager into MODSOURMAN-1063-2 # Conflicts: # NEWS.md # mod-source-record-manager-server/src/main/java/org/folio/services/JournalRecordService.java # mod-source-record-manager-server/src/main/java/org/folio/services/JournalRecordServiceImpl.java
|
Schema changes will be done in the separate PR after this implementation will be tested. For testing purposes changes in schema is provided in this way in .raml-file: |
|
Also, currently I'm working on fixing/improving unit-tests. |
VRohach
requested review from
KaterynaSenchenko,
RuslanLavrov,
RomanChernetskyi and
yaroslav-epam
yaroslav-epam
force-pushed
the
UXPROD-4471
branch
from
34ef783 to
ac69b58
Compare
…-record-manager into MODSOURMAN-1063-2 # Conflicts: # NEWS.md # mod-source-record-manager-server/src/main/java/org/folio/services/ChangeEngineServiceImpl.java # mod-source-record-manager-server/src/main/java/org/folio/services/JournalRecordService.java # mod-source-record-manager-server/src/main/java/org/folio/services/JournalRecordServiceImpl.java # mod-source-record-manager-server/src/test/java/org/folio/rest/impl/AbstractRestTest.java # mod-source-record-manager-server/src/test/java/org/folio/rest/impl/changeManager/ChangeManagerAPITest.java # mod-source-record-manager-server/src/test/java/org/folio/services/ChangeEngineServiceImplTest.java
VRohach
changed the title
This should be done when merging to master-branch!!! |
yaroslav-epam
force-pushed
the
UXPROD-4471
branch
from
ac69b58 to
e708698
Compare
…-record-manager into MODSOURMAN-1063-2 # Conflicts: # NEWS.md # mod-source-record-manager-server/src/main/java/org/folio/services/JournalRecordService.java # mod-source-record-manager-server/src/main/java/org/folio/services/JournalRecordServiceImpl.java # mod-source-record-manager-server/src/main/java/org/folio/services/journal/JournalUtil.java # mod-source-record-manager-server/src/main/resources/templates/db_scripts/create_get_job_log_entries_function.sql # mod-source-record-manager-server/src/main/resources/templates/db_scripts/schema.json
mod-source-record-manager-server/src/main/java/org/folio/dao/JournalRecordDaoImpl.java
Outdated
Show resolved
Hide resolved
KaterynaSenchenko
approved these changes
Jan 17, 2024
...g/folio/rest/impl/metadataProvider/MetaDataProviderRecordProcessingLogCollectionAPITest.java
Outdated
Show resolved
Hide resolved
yaroslav-epam
approved these changes
Jan 17, 2024
|
JavokhirAbdullayev
approved these changes
Jan 18, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Added incomingRecordId in https://github.com/folio-org/data-import-raml-storage/blob/master/schemas/dto/recordProcessingLogDto.json schema. SourceRecordId will still correspond to SRS record id, but may be empty if record is not saved in srs, therefore - remove sourceRecordId from "required" section
Checked specifics of Invoice Lines display. What 'relatedInvoiceLineInfo' refers to and add to ProcessingLogDto if needed
Made changes in MetadataProvider services and dao to populate incomingRecordId in ProcessingLogDto
Made changes in MetadataProvider for /metadata-provider/jobLogEntries/{jobExecutionId} to return collection of ProcessingLogDto. jobLogEntryDtoCollection schema should be changed or new collection schema is added
Remove https://github.com/folio-org/data-import-raml-storage/blob/master/schemas/dto/jobLogEntryDto.json
Updated tests
Approach
get_job_log_entries function improved to be able to fill the "RecordProcessingLogDto"-entity in collection.
Depends on: folio-org/data-import-raml-storage#304
Is this change testable? If not - why?
Checklist