Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STCLI-256 turn off StrictMode when running tests #363

Merged
merged 2 commits into from
Nov 21, 2024
Merged

STCLI-256 turn off StrictMode when running tests #363

merged 2 commits into from
Nov 21, 2024

Conversation

zburke
Copy link
Member

@zburke zburke commented Nov 21, 2024

<StrictMode> is intended to be a development-only setting so it should be disabled when running tests. e.g. a component that fetches data on mount with accumulate: true would see that data duplicated.

Refs STCLI-256

`<StrictMode>` is intended to be a development-only setting so it should
be disabled when running tests. e.g. a component that fetches data on
mount with `accumulate: true` would see that data duplicated.

Refs STCLI-256
@zburke zburke requested review from BogdanDenis, JohnC-80 and a team November 21, 2024 17:00
Copy link

github-actions bot commented Nov 21, 2024

Jest Unit Test Results

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit 9943442. ± Comparison against base commit 8bcddbf.

♻️ This comment has been updated with latest results.

@zburke zburke merged commit 798f10c into master Nov 21, 2024
25 checks passed
@zburke zburke deleted the STCLI-256 branch November 21, 2024 18:17
zburke added a commit that referenced this pull request Nov 25, 2024
`<StrictMode>` is intended to be a development-only setting so it should
be disabled when running tests. e.g. a component that fetches data on
mount with `accumulate: true` would see that data duplicated.

Refs STCLI-256

(cherry picked from commit 798f10c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants