-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STSMACOM-875 Use <IfAnyPermission>
and stripes.hasAnyPerm
to check for Notes assign/unassign perm.
#1538
Conversation
…k for Notes assign/unassign perm.
Bigtest Unit Test Results 1 files ± 0 1 suites ±0 0s ⏱️ -14s Results for commit c7d5600. ± Comparison against base commit 45615a8. This pull request removes 502 and adds 1 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes LGTM but please make sure to set the minimum stripes-core version correctly in package.json
: <IfAny>
requires ^10.2.3
.
package.json
Outdated
@@ -47,7 +47,7 @@ | |||
"@folio/stripes-cli": "^3.0.0", | |||
"@folio/stripes-components": "^12.0.0", | |||
"@folio/stripes-connect": "^9.0.0", | |||
"@folio/stripes-core": "^10.0.0", | |||
"@folio/stripes-core": "^10.2.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<IfAny>
doesn't show up until ^10.2.3
6104fa4
to
3bb7e18
Compare
…ks (#1564) Updating `stripes-core` in SSC causes 30+ tests to fail. folio-org/stripes-smart-components#1538 This PR addresses some issues which cause these failures. Overwriting of initial okapi and discovery data in `setupApplication` helper. Some tests require custom okapi data, but `setupApplication` in some cases can overwrite that data which makes those tests fail. Still investigating a few failing tests so maybe there's something else that needs to be fixed.
3bb7e18
to
5983e8f
Compare
d43d302
to
bcace68
Compare
bcace68
to
19a8334
Compare
Quality Gate passedIssues Measures |
…ks (#1564) Updating `stripes-core` in SSC causes 30+ tests to fail. folio-org/stripes-smart-components#1538 This PR addresses some issues which cause these failures. Overwriting of initial okapi and discovery data in `setupApplication` helper. Some tests require custom okapi data, but `setupApplication` in some cases can overwrite that data which makes those tests fail. Still investigating a few failing tests so maybe there's something else that needs to be fixed. (cherry picked from commit 1c73afd)
…k for Notes assign/unassign perm. (#1538) ## Description It seems that permission's `replaces` property doesn't work as it was expected to, so we have to check for both old and new permission names. Use `<IfAnyPermission>` and `stripes.hasAnyPerm` to check for Notes assign/unassign perm. ## Screenshots ![image](https://github.com/user-attachments/assets/079600d9-5e93-4ab2-8196-a0d78c08975c) ## Issues [STSMACOM-875](https://folio-org.atlassian.net/browse/STSMACOM-875) (cherry picked from commit fee9ec8)
Description
It seems that permission's
replaces
property doesn't work as it was expected to, so we have to check for both old and new permission names.Use
<IfAnyPermission>
andstripes.hasAnyPerm
to check for Notes assign/unassign perm.Screenshots
Issues
STSMACOM-875