Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIQM-591 Show permission quickMARC: Create a new MARC authority record. Don't load locations when MARC type is not Holdings. #624

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

BogdanDenis
Copy link
Contributor

Description

Don't load locations when MARC type is not Holdings.

Issues

UIQM-591

…rd`. Don't load locations when MARC type is not Holdings.
@BogdanDenis BogdanDenis requested review from Dmytro-Melnyshyn and a team November 28, 2023 09:29
Copy link

github-actions bot commented Nov 28, 2023

Jest Unit Test Statistics

    1 files  ±0    39 suites  ±0   2m 13s ⏱️ -2s
320 tests ±0  320 ✔️ ±0  0 💤 ±0  0 ±0 
321 runs  ±0  321 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 8d6e192. ± Comparison against base commit f8e2f1a.

♻️ This comment has been updated with latest results.

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

66.7% 66.7% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.17) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@@ -6,6 +6,7 @@
* [UIQM-543](https://issues.folio.org/browse/UIQM-543) Remove eslint deps that are already listed in eslint-config-stripes.
* [UIQM-573](https://issues.folio.org/browse/UIQM-573) Edit MARC authority | Allow user to Add/Edit 010 $a when linking is based on 001.
* [UIQM-574](https://issues.folio.org/browse/UIQM-574) Added authority source file selection button and modal to Authority Create view.
* [UIQM-591](https://issues.folio.org/browse/UIQM-591) Show permission `quickMARC: Create a new MARC authority record`. Don't load locations when MARC type is not Holdings.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the text Show permission quickMARC: Create a new MARC authority record be removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This permission was enabled before, but I didn't update the changelog

@Dmytro-Melnyshyn Dmytro-Melnyshyn requested a review from a team November 28, 2023 09:42
@Dmitriy-Litvinenko Dmitriy-Litvinenko requested a review from a team November 28, 2023 09:44
@BogdanDenis BogdanDenis merged commit 5fb6c3c into master Nov 28, 2023
4 checks passed
@BogdanDenis BogdanDenis deleted the UIQM-591 branch November 28, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants