Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIQM-591 Show permission quickMARC: Create a new MARC authority record. Don't load locations when MARC type is not Holdings. #624

Merged
merged 1 commit into from
Nov 28, 2023
Merged

UIQM-591 Show permission quickMARC: Create a new MARC authority record. Don't load locations when MARC type is not Holdings. #624

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
* [UIQM-543](https://issues.folio.org/browse/UIQM-543) Remove eslint deps that are already listed in eslint-config-stripes.
* [UIQM-573](https://issues.folio.org/browse/UIQM-573) Edit MARC authority | Allow user to Add/Edit 010 $a when linking is based on 001.
* [UIQM-574](https://issues.folio.org/browse/UIQM-574) Added authority source file selection button and modal to Authority Create view.
* [UIQM-591](https://issues.folio.org/browse/UIQM-591) Show permission `quickMARC: Create a new MARC authority record`. Don't load locations when MARC type is not Holdings.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the text Show permission quickMARC: Create a new MARC authority record be removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This permission was enabled before, but I didn't update the changelog


## [7.0.4](https://github.com/folio-org/ui-quick-marc/tree/v7.0.4) (2023-11-09)

Expand Down
5 changes: 4 additions & 1 deletion src/QuickMarcEditor/QuickMarcEditorContainer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,10 @@ const QuickMarcEditorContainer = ({
...headers,
});

const locationsPromise = mutator.locations.GET(headers);
const locationsPromise = marcType === MARC_TYPES.HOLDINGS
? mutator.locations.GET(headers)
: Promise.resolve();

// must be with the central tenant id when user derives shared record
const linkingRulesPromise = mutator.linkingRules.GET(headers);

Expand Down
Loading