UIREQ-1032, UIREQ-1034, UIREQ-1035 - Request detail view update for Lending, Borrowing and Pickup DCB roles #1118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ending, Borrowing and Pickup DCB roles
src/ViewRequest.test.js
Outdated
| }); | ||
|
|
||
| it('should not render "Duplicate" button', () => { | ||
| it('should not render "Dublicate" button', () => { |
There was a problem hiding this comment.
Suggested change
| it('should not render "Dublicate" button', () => { | |
| it('should not render "Duplicate" button', () => { |
There was a problem hiding this comment.
I see on the application that the button name is "Duplicate"
There was a problem hiding this comment.
Right, but you renamed it to duBlicate
src/ViewRequest.test.js
Outdated
| expect(screen.queryByText(labelIds.reorderQueue)).not.toBeInTheDocument(); | ||
| }); | ||
|
|
||
| // describe('when request is valid', () => { |
There was a problem hiding this comment.
Remove commented tests if they are not needed
src/ViewRequest.test.js
Outdated
| expect(screen.queryByText(labelIds.reorderQueue)).not.toBeInTheDocument(); | ||
| }); | ||
|
|
||
| // describe('when request is valid', () => { |
| value: title, | ||
| }; | ||
|
|
||
| expect(KeyValue).toHaveBeenNthCalledWith( |
There was a problem hiding this comment.
I don't see checking for a link in this test case actually
There was a problem hiding this comment.
- The test case intends to check that it is a not a link.
- line#32 declares title as a mere string, against which the assertion is made.
I think this is sufficient.
BogdanDenis
approved these changes
Nov 7, 2023
mariia-aloshyna
approved these changes
Nov 7, 2023
gurleenkaurbp
approved these changes
Nov 9, 2023
11 tasks
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Reshare DCB is a feature that allows sharing of assets within consortium.
Folio has primarily 3 roles in this feature - Lending, Borrowing, Pickup
Lending Role
Borrowing Role
Pickup Role
More details of the feature are available at https://wiki.folio.org/display/FOLIJET/DCB+Integration
Approach
Refs
UIREQ-1032 -[DCB] Request details: Hide all actions except "Cancel Request" in Action menu (Lending library)
UIREQ-1034 - [DCB] Request details: Updates for Action menu and DCB item links (Borrowing library)
UIREQ-1035 - [DCB] Request details: Updates for Action menu and DCB item links (Pickup library)
Screenshots
Two-legged transaction
Lending flow -
Request Status - Open-Not yet filled
Request Status - Open-In transit
Request Status - Open-Awaiting pickup
Request Status - Closed-Filled
Borrowing & Pickup flow -
Request Status - Open-Not yet filled
Request Status - Closed-Filled
Pre-Merge Checklist
Before merging this PR, please go through the following list and take appropriate actions.
If there are breaking changes, please STOP and consider the following:
Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.
While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.